Conversation
ljharb
reviewed
Jul 8, 2024
Member
ljharb
left a comment
There was a problem hiding this comment.
The "writes up to error" tests fail on my polyfill, so I'll review those after trying to fix my bug, but otherwise they look OK. omit-padding tests pass for me.
test/built-ins/Uint8Array/prototype/setFromBase64/writes-up-to-error.js
Outdated
Show resolved
Hide resolved
ljharb
approved these changes
Jul 8, 2024
Member
ljharb
left a comment
There was a problem hiding this comment.
confirmed, once i updated my implementation to match the updated spec, tests all pass.
ljharb
added a commit
to es-shims/es-arraybuffer-base64
that referenced
this pull request
Jul 8, 2024
…-error.js Co-authored-by: Jordan Harband <ljharb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for tc39/proposal-arraybuffer-base64#60 and tc39/proposal-arraybuffer-base64#58, which got consensus after the proposal had achieved stage 3 based on user and implementer feedback.
Based on #3994 (which incidentally is ready).