Editorial: Replace BalanceISODate with addition#3204
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
==========================================
- Coverage 97.83% 97.82% -0.01%
==========================================
Files 22 22
Lines 10381 10364 -17
Branches 1810 1810
==========================================
- Hits 10156 10139 -17
Misses 205 205
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
reviewed
Dec 11, 2025
Collaborator
ptomato
left a comment
There was a problem hiding this comment.
Thanks very much! I think this can be merged after some minor fixes.
ptomato
reviewed
Dec 12, 2025
24fba9c to
ad22159
Compare
deb525b to
d5f025e
Compare
ptomato
approved these changes
Jan 13, 2026
Collaborator
ptomato
left a comment
There was a problem hiding this comment.
There were some merge conflicts so I rebased this, and while at it I squashed the later edits into the original 4 commits (2 spec text, 2 reference implementation.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pulls out two of the editorial changes from #3184 . It replaces BalanceISODate with a new AddDaysToISODate operation, and also makes a minor editorial change to make use of signs clearer in DifferenceZonedDateTime.
I've left this as a series of commits for ease of review, but will squash before landing.