Replace BalanceISODate(Time) and rearrange time zone offset checks#3184
Closed
catamorphism wants to merge 36 commits intotc39:mainfrom
Closed
Replace BalanceISODate(Time) and rearrange time zone offset checks#3184catamorphism wants to merge 36 commits intotc39:mainfrom
catamorphism wants to merge 36 commits intotc39:mainfrom
Conversation
…ateTime' in polyfill
The check in the "timeZone === 'UTC'" case in GetPossibleEpochNanoseconds is necessary to make ZonedDateTime/p/since/roundingincrement-addition-out-of-range.js and ZonedDateTime/p/until/roundingincrement-addition-out-of-range.js pass. If it's changed to CheckISODaysRange(isoDateTime), that causes other test failures. Also changed and moved CheckISODaysRange(isoDateTime) test in InterpretISODateTimeOffset; this was to fix the following failures: FAIL: Duration/compare/relativeto-string-limits.js FAIL: Duration/p/round/relativeto-string-limits.js FAIL: Duration/p/total/relativeto-string-limits.js FAIL: ZonedDateTime/compare/argument-string-limits.js FAIL: ZonedDateTime/from/argument-string-limits.js FAIL: ZonedDateTime/p/equals/argument-string-limits.js FAIL: ZonedDateTime/p/since/argument-string-limits.js FAIL: ZonedDateTime/p/until/argument-string-limits.js
…bleEpochNanoseconds
…bleEpochNanoseconds'
…ore GetEpochNanosecondsFor
…ore GetEpochNanosecondsFor'
ff0e8db to
21fedcc
Compare
21fedcc to
b37b572
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
+ Coverage 96.96% 96.99% +0.03%
==========================================
Files 22 22
Lines 10219 10196 -23
Branches 1841 1850 +9
==========================================
- Hits 9909 9890 -19
+ Misses 261 257 -4
Partials 49 49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Note: not every step passes tests on its own. The first step breaks these tests: which are fixed in a later step. |
Collaborator
|
Closing, see #3014 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes #3014 and adds a commit implementing each spec change in the polyfill, following each of the spec commits.
Some test262 failures were revealed in the process, and the spec is changed accordingly, in separate commits so that it's easy to track what's different from #3014.