Rename Temporal.now => Temporal.Now#1645
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 19 19
Lines 10726 10726
Branches 1716 1716
=======================================
Hits 10190 10190
Misses 523 523
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ljharb
approved these changes
Jul 15, 2021
Member
ljharb
left a comment
There was a problem hiding this comment.
i only reviewed the one spec file; while i despise the capitalized form, this PR seems correct to me.
Ms2ger
requested changes
Jul 15, 2021
3c60880 to
365c462
Compare
ed9855a to
975be92
Compare
Ms2ger
approved these changes
Jul 16, 2021
justingrant
added a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Jul 16, 2021
Ms2ger
pushed a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Jul 16, 2021
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Jul 31, 2021
https://bugs.webkit.org/show_bug.cgi?id=228658 Patch by Philip Chimento <pchimento@igalia.com> on 2021-07-30 Reviewed by Yusuke Suzuki. See tc39/proposal-temporal#1645. In the July 2021 meeting TC39 achieved consensus to rename Temporal.now to Temporal.Now since it is a namespace. * runtime/TemporalNow.cpp: Change Now[@@toStringTag] accordingly. * runtime/TemporalObject.cpp: Rename now property to Now. Canonical link: https://commits.webkit.org/240138@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
philn
pushed a commit
to philn/old-webkit
that referenced
this pull request
Aug 1, 2021
https://bugs.webkit.org/show_bug.cgi?id=228658 Patch by Philip Chimento <pchimento@igalia.com> on 2021-07-30 Reviewed by Yusuke Suzuki. See tc39/proposal-temporal#1645. In the July 2021 meeting TC39 achieved consensus to rename Temporal.now to Temporal.Now since it is a namespace. * runtime/TemporalNow.cpp: Change Now[@@toStringTag] accordingly. * runtime/TemporalObject.cpp: Rename now property to Now. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@280506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1583 per today's consensus decision in TC39 plenary meeting.
Note that this PR does not include a
toStringTagimplementation. See #1539.