fixes #115: @@toStringTag is writable now#214
Conversation
|
While I appreciate the thumbs-ups, I actually need an approving review here to merge. Feedback from committee was to make this property writable. |
bakkot
left a comment
There was a problem hiding this comment.
LGTM but might be worth having an explicit emu-note calling out the unusual value and the reason for it; it's not obvious that this boilerplate is different from all the other boilerplate.
> Every other data property described in clauses 19 through 28 and in
> Annex B.2 has the attributes { [[Writable]]: true, [[Enumerable]]:
> false, [[Configurable]]: true } unless otherwise specified.
|
I've updated the PR to just remove the description of the property descriptor properties since
and these |
|
Per @bakkot's request, I've added a note anyway. |
Fixes #115. Option 2: just make
@@toStringTagwritable.