This repository was archived by the owner on Jan 25, 2022. It is now read-only.
Conversation
At the November 2017 TC39 meeting, the committee decided to demote static fields (both public and private) to a separate Stage 2 proposal. That proposal is being developed in https://github.com/tc39/proposal-static-class-features/ This patch removes static class fields from the class fields proposal in order to follow up on it in that other repository.
Member
Author
|
Merging this patch, as it has been out for review for a while, implements the consensus at TC39 and the alternate proposal is fully prepared and out for review. |
This was referenced Dec 21, 2017
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 22, 2017
This patch implements tc39/proposal-class-fields#65 and https://github.com/tc39/proposal-static-class-features/ by splitting out instance and static field declarations into separate flags for the separate proposals. Instance class fields is currently at Stage 3 whereas static class fields is currently at Stage 2. Bug: v8:5367 Change-Id: I133c945fd0b22dc5718c7bb61b10f22348087acd Reviewed-on: https://chromium-review.googlesource.com/839778 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#50293}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the November 2017 TC39 meeting, the committee decided to demote
static fields (both public and private) to a separate Stage 2 proposal.
That proposal is being developed in
https://github.com/tc39/proposal-static-class-features/
This patch removes static class fields from the class fields proposal
in order to follow up on it in that other repository.