Normative: Permit "unknown" DateTimeFormat/NumberFormat fields#245
Merged
littledan merged 1 commit intotc39:masterfrom Jul 28, 2018
Merged
Normative: Permit "unknown" DateTimeFormat/NumberFormat fields#245littledan merged 1 commit intotc39:masterfrom
littledan merged 1 commit intotc39:masterfrom
Conversation
In practice, libraries which underly ECMA-402 implementations may implement much of algorithms such as PartitionNumberFormat and PartitionDateTimeFormat. Sometimes, patterns from these algorithms will include unexpected fields. To handle these cases, this patch adds logic to represent them literally in the output of `format` methods. `formatToParts` methods use the "unknown" field type. This patch includes additional editorial/typo fixups: - Remove the previous logic to leave unrecognized fields in patterns in place (logic which was broken in DateTimeFormat) - Define ILD and ILND inline, to reduce confusion - Include some missing words in comparison
Member
Author
Member
Author
|
@jackhorton reported in July's ECMA-402 meeting that this change is implemented in ChakraCore. The change has consensus within the group, and was reported in the July 2018 TC39 meeting with no concerns raised. It's not really possible to write test262 tests. Given all that, it's ready to land. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 26, 2019
…DateTimeFormat. r=jwalden Nightly-only for now until the open spec issues are addressed. Drive-by change: Implement the "unknown" parts change from <tc39/ecma402#245>. Differential Revision: https://phabricator.services.mozilla.com/D38992 --HG-- extra : moz-landing-system : lando
dbaron
pushed a commit
to dbaron/gecko
that referenced
this pull request
Jul 26, 2019
…DateTimeFormat. r=jwalden Nightly-only for now until the open spec issues are addressed. Drive-by change: Implement the "unknown" parts change from <tc39/ecma402#245>. Differential Revision: https://phabricator.services.mozilla.com/D38992
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…DateTimeFormat. r=jwalden Nightly-only for now until the open spec issues are addressed. Drive-by change: Implement the "unknown" parts change from <tc39/ecma402#245>. Differential Revision: https://phabricator.services.mozilla.com/D38992 UltraBlame original commit: 74572aae39b00195dff4fdd7eef73eb7c28f1065
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…DateTimeFormat. r=jwalden Nightly-only for now until the open spec issues are addressed. Drive-by change: Implement the "unknown" parts change from <tc39/ecma402#245>. Differential Revision: https://phabricator.services.mozilla.com/D38992 UltraBlame original commit: 74572aae39b00195dff4fdd7eef73eb7c28f1065
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…DateTimeFormat. r=jwalden Nightly-only for now until the open spec issues are addressed. Drive-by change: Implement the "unknown" parts change from <tc39/ecma402#245>. Differential Revision: https://phabricator.services.mozilla.com/D38992 UltraBlame original commit: 74572aae39b00195dff4fdd7eef73eb7c28f1065
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…DateTimeFormat. r=jwalden Nightly-only for now until the open spec issues are addressed. Drive-by change: Implement the "unknown" parts change from <tc39/ecma402#245>. Differential Revision: https://phabricator.services.mozilla.com/D38992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice, libraries which underly ECMA-402 implementations may
implement much of algorithms such as PartitionNumberFormat and
PartitionDateTimeFormat. Sometimes, patterns from these algorithms
will include unexpected fields. To handle these cases, this patch
adds logic to represent them literally in the output of
formatmethods.
formatToPartsmethods use the "unknown" field type.This patch includes additional editorial/typo fixups:
in place (logic which was broken in DateTimeFormat)
Closes #231