Skip to content

Github Actions CI Process - Build Rust#49

Merged
nothingismagick merged 1 commit into
tauri-apps:devfrom
jbolda:feature/github-actions
Nov 2, 2019
Merged

Github Actions CI Process - Build Rust#49
nothingismagick merged 1 commit into
tauri-apps:devfrom
jbolda:feature/github-actions

Conversation

@jbolda

@jbolda jbolda commented Oct 31, 2019

Copy link
Copy Markdown
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: CI process

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This is following up on the discussion in #48. This PR currently builds anything with a cargo.toml as a minimal / first step check. Future steps may include building and testing against the smoke tests. Many of the builds currently fail though so not sure how we want to proceed with that. It may very well be my misunderstanding, but opening this to begin the discussion.

Here is an example of what a run will look like as it doesn't seem to have run on this PR.
https://github.com/jbolda/tauri/runs/276926274

* test lib on PR

* add build command

* ls to see where we are at

* ls after

* cd in one step

* less matrixes

* Rename test-lib-on-pr.yml to test-on-pr.yml

* pull out strategy

* Update test-on-pr.yml

* more spaces

* jobs don't like spaces

* test bindings

* build templates

* build tools

@nothingismagick nothingismagick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! Thankoyou for taking the time to do it!

@nothingismagick nothingismagick merged commit 1ee1933 into tauri-apps:dev Nov 2, 2019
DeepInThought pushed a commit to DeepInThought/tauri that referenced this pull request Dec 29, 2019
* test lib on PR

* add build command

* ls to see where we are at

* ls after

* cd in one step

* less matrixes

* Rename test-lib-on-pr.yml to test-on-pr.yml

* pull out strategy

* Update test-on-pr.yml

* more spaces

* jobs don't like spaces

* test bindings

* build templates

* build tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants