Github Actions CI Process - Build Rust#49
Merged
Conversation
* test lib on PR * add build command * ls to see where we are at * ls after * cd in one step * less matrixes * Rename test-lib-on-pr.yml to test-on-pr.yml * pull out strategy * Update test-on-pr.yml * more spaces * jobs don't like spaces * test bindings * build templates * build tools
nothingismagick
approved these changes
Nov 2, 2019
nothingismagick
left a comment
Member
There was a problem hiding this comment.
This is a great start! Thankoyou for taking the time to do it!
DeepInThought
pushed a commit
to DeepInThought/tauri
that referenced
this pull request
Dec 29, 2019
* test lib on PR * add build command * ls to see where we are at * ls after * cd in one step * less matrixes * Rename test-lib-on-pr.yml to test-on-pr.yml * pull out strategy * Update test-on-pr.yml * more spaces * jobs don't like spaces * test bindings * build templates * build tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch and not themasterbranchfix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This is following up on the discussion in #48. This PR currently builds anything with a cargo.toml as a minimal / first step check. Future steps may include building and testing against the smoke tests. Many of the builds currently fail though so not sure how we want to proceed with that. It may very well be my misunderstanding, but opening this to begin the discussion.
Here is an example of what a run will look like as it doesn't seem to have run on this PR.
https://github.com/jbolda/tauri/runs/276926274