Fix sort oscillation, skip redundant tree rebuilds, PEP 8 renames#411
Merged
realcarbonneau merged 1 commit intomasterfrom Mar 14, 2026
Merged
Fix sort oscillation, skip redundant tree rebuilds, PEP 8 renames#411realcarbonneau merged 1 commit intomasterfrom
realcarbonneau merged 1 commit intomasterfrom
Conversation
Sort idempotency: add UUID as first (least significant) sort pass to guarantee deterministic ordering for items with equal sort keys. Without this, pairs with identical subjects flip-flop on every re-sort due to the missing statusSortFunction silently falling back to subject (creating conflicting forward/reversed subject passes). Log the silent fallback so missing sort functions are visible. Skip redundant rebuilds: before deleting and recreating all tree nodes, snapshot the current tree structure (object IDs in depth-first order) and compare against what the presentation would produce. If identical, refresh items in place (text, colors, font) without rebuilding. Remove save freeze/rebuild: viewers no longer subscribe to aboutToSave/justSaved - saving to disk does not change the presentation. Narrow EventFilter to motion events only: clicks, keyboard, and scroll pass through so the app stays responsive during rebuilds. PEP 8 renames across sorter, viewer, container, frame, itemctrl, and all callers: snake_case for methods, locals, and parameters. Renamed ~80 identifiers across 22 files including sort_by, sort_keys, sort_ascending, sort_case_sensitive, sort_event_type, is_ascending, create_sort_key_function, add_pane, set_pane_title, docked_panes, is_center_pane, bind_events, active_viewer, activate_viewer, add_viewer, close_viewer, advance_selection, components_created, is_showing_tasks/effort/notes/attachments/categories, on_begin_io, on_end_io, register_presentation_observers, send_viewer_status_event, on_presentation_changed, init_layout, set_title, show_sort_column, show_sort_order, expand_all, collapse_all, hide_column, check_all_categories, get_is_item_checked, on_item_popup_menu, on_drop_url/files/mail, on_column_click, on_end_column_resize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort idempotency: add UUID as first (least significant) sort pass to guarantee deterministic ordering for items with equal sort keys. Without this, pairs with identical subjects flip-flop on every re-sort due to the missing statusSortFunction silently falling back to subject (creating conflicting forward/reversed subject passes). Log the silent fallback so missing sort functions are visible.
Skip redundant rebuilds: before deleting and recreating all tree nodes, snapshot the current tree structure (object IDs in depth-first order) and compare against what the presentation would produce. If identical, refresh items in place (text, colors, font) without rebuilding.
Remove save freeze/rebuild: viewers no longer subscribe to aboutToSave/justSaved - saving to disk does not change the presentation.
Narrow EventFilter to motion events only: clicks, keyboard, and scroll pass through so the app stays responsive during rebuilds.
PEP 8 renames across sorter, viewer, container, frame, itemctrl, and all callers: snake_case for methods, locals, and parameters. Renamed ~80 identifiers across 22 files including sort_by, sort_keys, sort_ascending, sort_case_sensitive, sort_event_type, is_ascending, create_sort_key_function, add_pane, set_pane_title, docked_panes, is_center_pane, bind_events, active_viewer, activate_viewer, add_viewer, close_viewer, advance_selection, components_created, is_showing_tasks/effort/notes/attachments/categories, on_begin_io, on_end_io, register_presentation_observers, send_viewer_status_event, on_presentation_changed, init_layout, set_title, show_sort_column, show_sort_order, expand_all, collapse_all, hide_column, check_all_categories, get_is_item_checked, on_item_popup_menu, on_drop_url/files/mail, on_column_click, on_end_column_resize.