Skip to content

Narrow EventFilter to motion events only, pass clicks and keyboard#410

Closed
realcarbonneau wants to merge 1 commit intomasterfrom
fix-motion-only-filter
Closed

Narrow EventFilter to motion events only, pass clicks and keyboard#410
realcarbonneau wants to merge 1 commit intomasterfrom
fix-motion-only-filter

Conversation

@realcarbonneau
Copy link
Copy Markdown
Contributor

The input filter was eating all mouse, keyboard, and scroll events during rebuild + 1s settling period, making the app feel unresponsive (lost clicks, lost keystrokes). Only motion events drive the AUI cascade (OnMotion -> hover -> repaint -> repeat). Clicks, keyboard, and scroll do not contribute to the cascade and should pass through.

Narrowed _MOTION_EVENTS to wxEVT_MOTION, wxEVT_ENTER_WINDOW, wxEVT_LEAVE_WINDOW only. Updated LIST_MANAGEMENT.md with the abandoned approach (#13) and revised architecture description.

The input filter was eating all mouse, keyboard, and scroll events
during rebuild + 1s settling period, making the app feel unresponsive
(lost clicks, lost keystrokes).  Only motion events drive the AUI
cascade (OnMotion -> hover -> repaint -> repeat).  Clicks, keyboard,
and scroll do not contribute to the cascade and should pass through.

Narrowed _MOTION_EVENTS to wxEVT_MOTION, wxEVT_ENTER_WINDOW,
wxEVT_LEAVE_WINDOW only.  Updated LIST_MANAGEMENT.md with the
abandoned approach (#13) and revised architecture description.
@realcarbonneau realcarbonneau deleted the fix-motion-only-filter branch March 14, 2026 03:46
realcarbonneau added a commit that referenced this pull request Mar 14, 2026
Sort idempotency: add UUID as first (least significant) sort pass to
guarantee deterministic ordering for items with equal sort keys.
Without this, pairs with identical subjects flip-flop on every re-sort
due to the missing statusSortFunction silently falling back to subject
(creating conflicting forward/reversed subject passes).  Log the
silent fallback so missing sort functions are visible.

Skip redundant rebuilds: before deleting and recreating all tree nodes,
snapshot the current tree structure (object IDs in depth-first order)
and compare against what the presentation would produce.  If identical,
refresh items in place (text, colors, font) without rebuilding.

Remove save freeze/rebuild: viewers no longer subscribe to
aboutToSave/justSaved - saving to disk does not change the
presentation.

Narrow EventFilter to motion events only: clicks, keyboard, and scroll
pass through so the app stays responsive during rebuilds.

PEP 8 renames across sorter, viewer, container, frame, itemctrl, and
all callers: snake_case for methods, locals, and parameters.  Renamed
~80 identifiers across 22 files including sort_by, sort_keys,
sort_ascending, sort_case_sensitive, sort_event_type, is_ascending,
create_sort_key_function, add_pane, set_pane_title, docked_panes,
is_center_pane, bind_events, active_viewer, activate_viewer,
add_viewer, close_viewer, advance_selection, components_created,
is_showing_tasks/effort/notes/attachments/categories, on_begin_io,
on_end_io, register_presentation_observers, send_viewer_status_event,
on_presentation_changed, init_layout, set_title, show_sort_column,
show_sort_order, expand_all, collapse_all, hide_column,
check_all_categories, get_is_item_checked, on_item_popup_menu,
on_drop_url/files/mail, on_column_click, on_end_column_resize.
@realcarbonneau realcarbonneau restored the fix-motion-only-filter branch March 14, 2026 22:09
@realcarbonneau realcarbonneau deleted the fix-motion-only-filter branch March 14, 2026 22:23
realcarbonneau added a commit that referenced this pull request Mar 19, 2026
The PEP 8 rename in PR #410 renamed get_is_item_checked and
get_item_parent_has_exclusive_children in category.py and treectrl.py
but missed the implementations in CheckableTaskViewer (task.py:2244).
This caused an AttributeError crash when opening the Prerequisites
tab in the task editor.
realcarbonneau added a commit that referenced this pull request Mar 19, 2026
The PEP 8 rename in PR #410 renamed get_is_item_checked and
get_item_parent_has_exclusive_children in category.py and treectrl.py
but missed the implementations in CheckableTaskViewer (task.py:2244).
This caused an AttributeError crash when opening the Prerequisites
tab in the task editor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant