Conversation
|
Hi @Jogai, if I understood A new rust shell #265 correctly, the electron dependency was replaced by tauri. |
|
@surfmuggle eventually yes. IF the rust version proves to be stable, easy to distribute, and not give everyone grief just trying to install/run it... then yes I think the rust shell is the better option and Electron will be dropped. Until then however I will continue to distribute Electron builds of NetPad. I think the Electron version will stick around for the foreseeable future (at least a few more months if not more) so feel free to use either. This PR is still of interest, I'll dedicate some more time soon to push it forward. |
# Conflicts: # src/Core/NetPad.Runtime/NetPad.Runtime.csproj # src/External/OmniSharp.NET/OmniSharp.NET.csproj
Some packages are added because they would still resolve to older versions
057aafb to
c238b16
Compare
|
Thank you @Jogai for all the work you've done on this. I'll give this more love as soon as I get the next release out. |
|
@Jogai I've started going through the changes with the hopes to get this merged in the next few days. You've obviously spent alot of time putting this together, I appreciate it! I'll let you know if there are any changes we'll need. So far, the only thing I see that we might need to revert is that you've removed support for .NET 6 and .NET 7 (for example here and here and a few other spots). Any reason you did that? I understand they're technically out of support, but I still want NetPad to continue supporting those versions for users that need them. |
|
@tareqimbasher regarding your question why support for .NET 6 and .NET 7 was removed. In #270 (comment) Jogai wrote
|
|
This PR includes a few changes bundled together. I'm going to create a new PR, referencing this one, that only adds the changes that we want from this change. Below I've outlined the changes this PR includes and whether each change will make it into the new PR:
I've already copied the changes for the first 2 changes (thank you again @Jogai for all your hard work on this!) onto a local branch and I'm currently testing it. I'm also waiting on this PR that I submitted to ElectronSharp that needs to be merged to fix a breaking change in Electron36 when running on Linux. I will update here with new developments. Thank you both. |
|
PR on ElectronSharp was merged and a new version was published which fixed the issue on Linux. These are the two remaining items I'm working on fixing before the switch is complete:
|
|
PR #352 is now merged and contains all changes mentioned in #274 (comment). I will be releasing a NetPad update soon with the new Electron36. |
Two tests still fail, but most of the syntax is okay