Add ability to set switch value in manifest cliFlags property#37
Merged
theolivenbaum merged 1 commit intotheolivenbaum:mainfrom Jun 30, 2025
Merged
Add ability to set switch value in manifest cliFlags property#37theolivenbaum merged 1 commit intotheolivenbaum:mainfrom
theolivenbaum merged 1 commit intotheolivenbaum:mainfrom
Conversation
main.js adds command line switches to the spawned electron process if "cliFlags" property has values in electron.manifest.json, but it does not allow setting a value for the switch. This change splits each item in the cliFlags array on the first '=' and sets the switch value, if provided.
Contributor
Author
|
@theolivenbaum any chance this can get merged soon? It is a blocker right now that's stopping a PR on my end to migrate from Electron.NET to ElectronSharp. It's a simple change that I hope won't take too long to review. Please and thank you! |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main.jsadds command line switches to the spawned electron process if "cliFlags" property has values inelectron.manifest.json, but it does not allow setting a value for the switch. This change splits each item in the cliFlags array on the first '=' and sets the switch value, if provided.This came up due to the new Electron 36 breaking change on Linux when running GNOME and attempting to apply the fix.