Skip to content

[backport 3.5] box: export txn savepoint symbols#11913

Merged
sergepetrenko merged 1 commit intorelease/3.5from
backport/release/3.5/11903
Oct 10, 2025
Merged

[backport 3.5] box: export txn savepoint symbols#11913
sergepetrenko merged 1 commit intorelease/3.5from
backport/release/3.5/11903

Conversation

@TarantoolBot
Copy link
Collaborator

@TarantoolBot TarantoolBot commented Oct 10, 2025

(This PR is a backport of #11903 to release/3.5 to a future 3.5.1 release.)


When txn savepoint machinery was implemented, its functions were marked with API_EXPORT qualifier and they were added to extra/exports list. However, they were decalred out of cond public scope, so they weren't exported actually - the commit fixes that mistake.

Along the way, the commit covers exported functions controlling transaction flow with tests.

Closes #11731

When txn savepoint machinery was implemented, its functions were marked
with API_EXPORT qualifier and they were added to `extra/exports` list.
However, they were decalred out of `cond public` scope, so they weren't
exported actually - the commit fixes that mistake.

Along the way, the commit covers exported functions controlling
transaction flow with tests.

Closes #11731

@TarantoolBot document

Title: Fix txn savepoint methods in C API
Since: 3.2.3, 3.3.4, 3.4.2, 3.5.1, 3.6.0

Current documentation contains incorrect definitions of savepoint
related functions. The correct ones are:

```c
API_EXPORT box_txn_savepoint_t *
box_txn_savepoint(void);

API_EXPORT int
box_txn_rollback_to_savepoint(box_txn_savepoint_t *savepoint);
```

Also, these functions were not exported by mistake. So we should delete
them from docs of old Tarantool versions or write a note explaining that
these methods were forgotten and one can find them in newer versions.

(cherry picked from commit 8a1dad8)
@TarantoolBot TarantoolBot requested a review from a team as a code owner October 10, 2025 13:05
@TarantoolBot TarantoolBot added the full-ci Enables all tests for a pull request label Oct 10, 2025
@TarantoolBot TarantoolBot changed the title [Backport release/3.5] box: export txn savepoint symbols [backport 3.5] box: export txn savepoint symbols Oct 10, 2025
@sergepetrenko sergepetrenko removed the full-ci Enables all tests for a pull request label Oct 10, 2025
@coveralls
Copy link

Coverage Status

coverage: 87.607% (-0.004%) from 87.611%
when pulling 023a9bf on backport/release/3.5/11903
into e0f41b0
on release/3.5
.

@sergepetrenko sergepetrenko merged commit 22f7a56 into release/3.5 Oct 10, 2025
41 of 60 checks passed
@sergepetrenko sergepetrenko deleted the backport/release/3.5/11903 branch October 10, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants