box: export txn savepoint symbols#11903
Merged
sergepetrenko merged 1 commit intotarantool:masterfrom Oct 10, 2025
Merged
Conversation
Contributor
Author
|
Are we going to back port this fix? To which version will it be backported (I will update doc request accordingly). |
f607c3b to
914333d
Compare
Collaborator
|
@drewdzzz, this is a bugfix, so it should go to all currently supported versions. That is, 3.2 and newer |
Gumix
approved these changes
Oct 8, 2025
914333d to
cd66420
Compare
Contributor
Author
|
@sergepetrenko updated doc request: I hope doc team won't be confused... |
maryiaLichko
approved these changes
Oct 10, 2025
When txn savepoint machinery was implemented, its functions were marked with API_EXPORT qualifier and they were added to `extra/exports` list. However, they were decalred out of `cond public` scope, so they weren't exported actually - the commit fixes that mistake. Along the way, the commit covers exported functions controlling transaction flow with tests. Closes tarantool#11731 @TarantoolBot document Title: Fix txn savepoint methods in C API Since: 3.2.3, 3.3.4, 3.4.2, 3.5.1, 3.6.0 Current documentation contains incorrect definitions of savepoint related functions. The correct ones are: ```c API_EXPORT box_txn_savepoint_t * box_txn_savepoint(void); API_EXPORT int box_txn_rollback_to_savepoint(box_txn_savepoint_t *savepoint); ``` Also, these functions were not exported by mistake. So we should delete them from docs of old Tarantool versions or write a note explaining that these methods were forgotten and one can find them in newer versions.
sergepetrenko
approved these changes
Oct 10, 2025
Collaborator
sergepetrenko
left a comment
There was a problem hiding this comment.
Thanks for the fix!
| @@ -0,0 +1,4 @@ | |||
| ## bugfix/box | |||
Collaborator
There was a problem hiding this comment.
we use /core instead of /box in the changelogs now.
a47a6b8 to
18e8835
Compare
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.2
git worktree add -d .worktree/backport/release/3.2/11903 origin/release/3.2
cd .worktree/backport/release/3.2/11903
git switch --create backport/release/3.2/11903
git cherry-pick -x 8a1dad8aa00c16d8c48722533e77ff7640398623 |
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.3
git worktree add -d .worktree/backport/release/3.3/11903 origin/release/3.3
cd .worktree/backport/release/3.3/11903
git switch --create backport/release/3.3/11903
git cherry-pick -x 8a1dad8aa00c16d8c48722533e77ff7640398623 |
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.4
git worktree add -d .worktree/backport/release/3.4/11903 origin/release/3.4
cd .worktree/backport/release/3.4/11903
git switch --create backport/release/3.4/11903
git cherry-pick -x 8a1dad8aa00c16d8c48722533e77ff7640398623 |
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
|
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When txn savepoint machinery was implemented, its functions were marked with API_EXPORT qualifier and they were added to
extra/exportslist. However, they were decalred out ofcond publicscope, so they weren't exported actually - the commit fixes that mistake.Along the way, the commit covers exported functions controlling transaction flow with tests.
Closes #11731