[backport 3.3] log: fix truncating log message to 1024 bytes in 'json' log#11142
Merged
Totktonada merged 1 commit intorelease/3.3from Feb 12, 2025
Merged
[backport 3.3] log: fix truncating log message to 1024 bytes in 'json' log#11142Totktonada merged 1 commit intorelease/3.3from
Totktonada merged 1 commit intorelease/3.3from
Conversation
Before this patch, when log format was set to 'json' and log entry was
written with format-string API (`require('log').info(<format string>,
args...)`), in the output the message was truncated to 1024 bytes.
This patch fixes this behavior, and now the message will only be
truncated if the full log entry (with all the context) doesn't fit into
the 16KiB buffer. The message will be truncated in a way, so all the
context is present.
Closes #10918
NO_DOC=bugfix
(cherry picked from commit 6b891b4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is a backport of #10952 to
release/3.3to a future3.3.2release.)Before this patch, when log format was set to 'json' and log entry was written with format-string API (
require('log').info(<format string>, args...)), in the output the message was truncated to 1024 bytes.This patch fixes this behavior, and now the message will only be truncated if the full log entry (with all the context) doesn't fit into the 16KiB buffer. The message will be truncated in a way, so all the context is present.
Closes #10918
NO_DOC=bugfix