log: fix truncating log message to 1024 bytes in 'json' log#10952
Merged
Totktonada merged 1 commit intotarantool:masterfrom Feb 12, 2025
Merged
log: fix truncating log message to 1024 bytes in 'json' log#10952Totktonada merged 1 commit intotarantool:masterfrom
Totktonada merged 1 commit intotarantool:masterfrom
Conversation
7158df1 to
0441fc1
Compare
f859dd7 to
8661f19
Compare
8661f19 to
82dce67
Compare
82dce67 to
cbe3e3b
Compare
locker
reviewed
Dec 24, 2024
lenkis
approved these changes
Dec 25, 2024
71eba06 to
8e7ba90
Compare
4c6a668 to
0760e0a
Compare
Member
Author
|
I've added more tap tests (luatest tests will be developed in scope of reworking the logger module task). Current solution works fine for |
0760e0a to
90e2f05
Compare
6f104a9 to
e825d01
Compare
fa04942 to
0146922
Compare
Before this patch, when log format was set to 'json' and log entry was
written with format-string API (`require('log').info(<format string>,
args...)`), in the output the message was truncated to 1024 bytes.
This patch fixes this behavior, and now the message will only be
truncated if the full log entry (with all the context) doesn't fit into
the 16KiB buffer. The message will be truncated in a way, so all the
context is present.
Closes tarantool#10918
NO_DOC=bugfix
0146922 to
7435752
Compare
Collaborator
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/2.11
git worktree add -d .worktree/backport/release/2.11/10952 origin/release/2.11
cd .worktree/backport/release/2.11/10952
git switch --create backport/release/2.11/10952
git cherry-pick -x 6b891b4f7648113ed6501d8957f07411d1a33368 |
Collaborator
|
Successfully created backport PR for |
This was referenced Feb 12, 2025
Collaborator
|
Successfully created backport PR for |
Collaborator
Backport summary
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, when log format was set to 'json' and log entry was written with format-string API (
require('log').info(<format string>, args...)), in the output the message was truncated to 1024 bytes.This patch fixes this behavior, and now the message will only be truncated if the full log entry (with all the context) doesn't fit into the 16KiB buffer. The message will be truncated in a way, so all the context is present.
Closes #10918
NO_DOC=bugfix