Skip to content

Fix crash in small when when slab_alloc_factor is low and memory pressure is high#10519

Merged
locker merged 2 commits intotarantool:masterfrom
nshy:fix-small-crash-low-alloc-factor
Sep 9, 2024
Merged

Fix crash in small when when slab_alloc_factor is low and memory pressure is high#10519
locker merged 2 commits intotarantool:masterfrom
nshy:fix-small-crash-low-alloc-factor

Conversation

@nshy
Copy link
Contributor

@nshy nshy commented Sep 5, 2024

Closes #10148

Small PR tarantool/small#94

@nshy nshy requested a review from a team as a code owner September 5, 2024 08:37
@nshy nshy requested a review from locker September 5, 2024 08:51
@coveralls
Copy link

coveralls commented Sep 5, 2024

Coverage Status

coverage: 87.231% (+0.003%) from 87.228%
when pulling 275282a on nshy:fix-small-crash-low-alloc-factor
into 9dbaa6a
on tarantool:master
.

@locker locker added the do not merge Not ready to be merged label Sep 5, 2024
@locker locker assigned nshy and unassigned locker Sep 5, 2024
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch 2 times, most recently from f05b71a to f6f82e1 Compare September 5, 2024 14:45
@nshy nshy assigned locker and nshy and unassigned nshy and locker Sep 6, 2024
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch from f6f82e1 to f9ff5f6 Compare September 6, 2024 07:32
@nshy nshy assigned locker and unassigned nshy Sep 6, 2024
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch from f9ff5f6 to a7e1377 Compare September 6, 2024 07:37
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch 2 times, most recently from 82781ad to 038e50a Compare September 6, 2024 13:21
@nshy nshy removed the do not merge Not ready to be merged label Sep 6, 2024
@locker locker assigned nshy and unassigned locker Sep 6, 2024
nshy added 2 commits September 6, 2024 17:30
New commits:

* small: small: fix crash with low alloc_factor and high memory pressure
* test: get rid of debug message
* test: assign label to tests
* test: introduce a CMake function create_test

Part of tarantool#10148

NO_TEST=submodule bump
NO_CHANGELOG=submodule bump
NO_DOC=submodule bump
The fix itself is in the small submodule which is bumped in the previous
commit.

Closes tarantool#10148

NO_DOC=bugfix
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch from 038e50a to 275282a Compare September 6, 2024 14:37
@nshy nshy added the full-ci Enables all tests for a pull request label Sep 6, 2024
@nshy nshy assigned locker and unassigned nshy Sep 6, 2024
@locker locker merged commit e4ce9e1 into tarantool:master Sep 9, 2024
@locker
Copy link
Member

locker commented Sep 9, 2024

Cherry-picked to 2.11 and 3.2.

@nshy nshy deleted the fix-small-crash-low-alloc-factor branch September 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Enables all tests for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault in small_mempool_get_group_index ()

4 participants