Skip to content

small: fix crash with low alloc_factor and high memory pressure#94

Merged
locker merged 1 commit intotarantool:masterfrom
nshy:fix-small-crash-low-alloc-factor
Sep 6, 2024
Merged

small: fix crash with low alloc_factor and high memory pressure#94
locker merged 1 commit intotarantool:masterfrom
nshy:fix-small-crash-low-alloc-factor

Conversation

@nshy
Copy link
Contributor

@nshy nshy commented Sep 5, 2024

If alloc_factor is small so that number of small mempools is SMALL_MEMPOOL_MAX we fail to call small_mempool_create_groups() for the last group of mempools.

Needed for tarantool/tarantool#10148

Tarantool PR with bump tarantool/tarantool#10519

@locker locker assigned nshy and unassigned locker Sep 5, 2024
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch from d373711 to 87aef0b Compare September 5, 2024 13:43
@nshy nshy assigned locker and nshy and unassigned nshy and locker Sep 6, 2024
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch from 87aef0b to 88fdd04 Compare September 6, 2024 07:30
@nshy
Copy link
Contributor Author

nshy commented Sep 6, 2024

Make small_alloc_low_alloc_factor() run only for non ASAN version (the test references some internal details of non ASAN version of allocator).

@nshy nshy assigned locker and unassigned nshy Sep 6, 2024
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch from 88fdd04 to 6d35b67 Compare September 6, 2024 07:36
@locker locker assigned nshy and unassigned locker Sep 6, 2024
If alloc_factor is small so that number of small mempools is SMALL_MEMPOOL_MAX
we fail to call small_mempool_create_groups() for the last group of
mempools.

Needed for tarantool/tarantool#10148
@nshy nshy force-pushed the fix-small-crash-low-alloc-factor branch from 6d35b67 to dcd269b Compare September 6, 2024 11:51
@nshy nshy assigned locker and unassigned nshy Sep 6, 2024
@locker locker merged commit f508894 into tarantool:master Sep 6, 2024
@nshy nshy deleted the fix-small-crash-low-alloc-factor branch September 13, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants