Merged
Conversation
…theus -> metrics.details
ASverdlov
suggested changes
Feb 6, 2019
Contributor
ASverdlov
left a comment
There was a problem hiding this comment.
LGTM, I will merge this after fixes of logging level and README.
added 2 commits
February 7, 2019 14:26
…or it. Rewrite metrics README
Contributor
|
Please consider We probably need to adapt it. Internally we store histograms in |
Contributor
|
Decided to merge this. We'll handle |
no1seman
added a commit
that referenced
this pull request
Feb 22, 2021
olegrok
added a commit
that referenced
this pull request
Oct 8, 2025
Once I catched an error during tests: ``` tarantool/override/metrics/psutils/psutils_linux.lua:49: bad argument #1 to 'string.split' (string expected, got nil) ``` That shows that in some rare cases fio.read can return `nil, err` but before this patch this case was unhandled. This patch fixes it. Also it was pretty strange to print a message via "print" function. It was changed to "log" module that is more native for tarantool. This patch doesn't contain tests because it's pretty hard to reproduce such error (file was opened but `file:read()` returned an errors for some reasons). Closes #526
olegrok
added a commit
that referenced
this pull request
Oct 8, 2025
Once I catched an error during tests: ``` tarantool/override/metrics/psutils/psutils_linux.lua:49: bad argument #1 to 'string.split' (string expected, got nil) ``` That shows that in some rare cases fio.read can return `nil, err` but before this patch this case was unhandled. This patch fixes it. Also it was pretty strange to print a message via "print" function. It was changed to "log" module that is more native for tarantool. This patch doesn't contain tests because it's pretty hard to reproduce such error (file was opened but `file:read()` returned an errors for some reasons). Closes #526
olegrok
added a commit
that referenced
this pull request
Oct 9, 2025
Once I catched an error during tests: ``` tarantool/override/metrics/psutils/psutils_linux.lua:49: bad argument #1 to 'string.split' (string expected, got nil) ``` That shows that in some rare cases fio.read can return `nil, err` but before this patch this case was unhandled. This patch fixes it. Also it was pretty strange to print a message via "print" function. It was changed to "log" module that is more native for tarantool. This patch doesn't contain tests because it's pretty hard to reproduce such error (file was opened but `file:read()` returned an errors for some reasons). Closes #526
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added graphite export plugin and it's usage example.
Described how to create custom export plugin.
Renamed metrics.details.prometheus -> metrics.details.