@claude review

Claude finished @drewstone's task —— View job

Code Review for PR #1164: Bump eigensdk & alloy version

I've completed my review of the dependency upgrades and associated code changes.

Review Tasks:

• Analyze dependency version updates for breaking changes
• Review API migration changes in core modules
• Check module path updates (camelCase to snake_case)
• Verify example and test updates
• Look for potential issues or improvements
• Post comprehensive review feedback

Review Summary

This PR updates major dependencies with several breaking API changes that have been mostly well-handled. However, there are a few issues that need to be addressed before merging.

✅ Correctly Migrated Changes

1. Provider API Updates - The migration from on_http/on_ws to connect_http/connect_ws in provider builders has been correctly applied across all files.

2. Module Path Updates - Most module paths have been correctly updated from camelCase to snake_case (e.g., registryCoordinator → registry_coordinator).

3. API Signature Changes:

   • Removed deprecated logger parameters from eigensdk calls
   • Updated decode_log calls to remove the boolean parameter
   • Correctly handled the get_receipt signature change

4. Feature Removal - The deprecated "logging" feature has been properly removed from eigensdk dependencies.

❌ Issues Found

1. Unused Import in crates/manager/src/config/mod.rs

use crate::error::{Error, Result};
                    ^^^^^ // Error is unused

Fix: Remove the unused Error import.

2. Incorrect Module Path in crates/clients/eigenlayer/src/tests.rs

Lines 12-13 use registrycoordinator (camelCase) instead of registry_coordinator (snake_case):

// Current (incorrect):
use eigenlayer_contract_deployer::bindings::core::registrycoordinator::...

// Should be:
use eigenlayer_contract_deployer::bindings::core::registry_coordinator::...

3. Dependency Conflict in cargo-tangle tests

The test test_run_eigenlayer_avs is failing due to a c-kzg version conflict. This appears to be a dependency resolution issue that needs investigation.

📋 Additional Observations

1. Version Pinning: All alloy dependencies are pinned to exact versions (e.g., =1.0.35), which is good for consistency but may require more frequent updates.

2. Contract Address Updates: The AVS contracts JSON has updated implementation addresses - ensure these are intentional and tested.

3. Build Script Feature: The new "build-script" feature has been added to eigenlayer-contract-deployer - verify this is required for the build process.

🔧 Required Actions

Before merging this PR:

1. Fix the unused import in crates/manager/src/config/mod.rs
2. Correct the module paths in crates/clients/eigenlayer/src/tests.rs (lines 12-13)
3. Investigate and resolve the c-kzg dependency conflict in cargo-tangle tests
4. Run cargo clippy -- -D warnings locally to catch any other linting issues

The migration appears largely successful, with these being relatively minor issues that should be straightforward to fix. The API changes are consistent with the major version bumps and follow the expected patterns for these libraries.

Job run • Branch

This upgrade depends on next release of foundry version with soldeer > v0.7.1 to fix issue Builder::init should not be called after logger initialized: SetLoggerError(()) itself

Steps to reproduce:

• Run cargo clean && RUST_LOG=incredible_squaring_blueprint_eigenlayer=trace ograc test --package incredible-squaring-blueprint-eigenlayer test_eigenlayer_incredible_squaring_blueprint -- --nocapture

But it still work normally if we run (without set the RUST_LOG target):

cargo test --package incredible-squaring-blueprint-eigenlayer test_eigenlayer_incredible_squaring_blueprint -- --nocapture

Does this release handle it @danielbui12 https://github.com/mario-eth/soldeer/releases/tag/v0.8.0

Does this release handle it @danielbui12 https://github.com/mario-eth/soldeer/releases/tag/v0.8.0

@drewstone yes it does. but in our code, we're using forge soldeer not soldeer directly

@danielbui12 It looks like these changes also introduced some new problems with the cargo-tangle tests. Clippy is also failing