Fix crash during upgrade when content globs escape root of project#14896
Merged
RobinMalfait merged 6 commits intonextfrom Nov 7, 2024
Merged
Fix crash during upgrade when content globs escape root of project#14896RobinMalfait merged 6 commits intonextfrom
RobinMalfait merged 6 commits intonextfrom
Conversation
dc3b046 to
29d6241
Compare
philipp-spiess
approved these changes
Nov 7, 2024
packages/@tailwindcss-upgrade/src/utils/hoist-static-glob-parts.ts
Outdated
Show resolved
Hide resolved
This is an implementation similar to what we already have in Rust. The idea is that we want to move the static parts to the `base` path. This allows us to use `..` in the pattern and the glob would be adjusted correctly. Without this, globby will error if your pattern escapes the base path by using `..` in the pattern.
…s.ts Co-authored-by: Philipp Spiess <hello@philippspiess.com>
f5bc8f7 to
17c7bda
Compare
thecrypticace
added a commit
that referenced
this pull request
Nov 7, 2024
This ensures our glob hoisting mechanism (see #14896) works on Windows when performing an upgrade. --------- Co-authored-by: Jordan Pittman <jordan@cryptica.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where globs in you
contentconfiguration escape the current "root" of the project.This can happen if you have a folder, and you need to look up in the tree (e.g.: when looking at another package in a monorepo, or in case of a Laravel project where you want to look at mail templates).
This applies a similar strategy we already implement on the Rust side.
patternto thebaseof the glob entry objectGiven a project setup like this:
If you then have this config:
Then before this change, running the command looks like this:

After this change, running the command looks like this:
