Ensure underscore in theme() are also preserved#14781
Merged
adamwathan merged 1 commit intonextfrom Oct 24, 2024
Merged
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @philipp-spiess and the rest of your teammates on |
20dfaef to
e44faf2
Compare
adamwathan
reviewed
Oct 24, 2024
Member
adamwathan
left a comment
There was a problem hiding this comment.
Can we think of any situation where it's important to handle theme(--spacing-1) and theme(spacing.1) differently here with regards to the underscore escape stuff?
e44faf2 to
a95eea9
Compare
Contributor
Author
|
@adamwathan It's a breaking change from v3 for sure but so is the I fear that the codemod should handle this or so and just replace it to |
adamwathan
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #14776 to treat the
theme()function the same way.