Skip to content

Fix crash#320

Merged
thecrypticace merged 2 commits intomainfrom
fix/plugin-crash
Sep 24, 2024
Merged

Fix crash#320
thecrypticace merged 2 commits intomainfrom
fix/plugin-crash

Conversation

@thecrypticace
Copy link
Contributor

We forgot a try/catch when we switched to enhanced-resolve for dynamic dependency loading. Oops…

@thecrypticace thecrypticace merged commit 081b4f5 into main Sep 24, 2024
@thecrypticace thecrypticace deleted the fix/plugin-crash branch September 24, 2024 17:31
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@thecrypticace
Copy link
Contributor Author

Yeeeep… enhanced-resolve was confusing for a bit because it can return false but it actually only ever does b/c of the aliasing plugin (which is used when using webpack I think).

So it actually still throws and I guess I removed the check and forgot to put it back. Our tests obvs didn't fail because the plugins are always there. Need to adjust the integration tests so they're run outside of the workspace — that would've caught this I think.

bronisMateusz pushed a commit to bronisMateusz/prettier-plugin-tailwindcss-drupal that referenced this pull request Apr 16, 2025
* Fix crash

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants