Skip to content

feat: multiple onRequest handlers#1863

Merged
tusharmath merged 26 commits intotailcallhq:mainfrom
webbdays:1271
Jun 7, 2024
Merged

feat: multiple onRequest handlers#1863
tusharmath merged 26 commits intotailcallhq:mainfrom
webbdays:1271

Conversation

@webbdays
Copy link
Copy Markdown
Contributor

@webbdays webbdays commented May 5, 2024 •
edited by tusharmath
Loading

Summary:
multiple onRequest handlers

Issue Reference(s):
Fixes #1271
/claim #1271

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • [yes ] PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label May 5, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented May 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.58838% with 43 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (bdd16df) to head (34af14a).

❗ Current head 34af14a differs from pull request most recent head d7d5c9e

Please upload reports for the commit d7d5c9e to get more accurate results.

Files Patch % Lines
src/core/worker.rs 87.61% 13 Missing ⚠️
src/core/ir/io.rs 85.36% 12 Missing ⚠️
src/cli/javascript/codec.rs 95.62% 8 Missing ⚠️
src/core/http/mod.rs 0.00% 3 Missing ⚠️
src/core/mod.rs 0.00% 3 Missing ⚠️
src/core/runtime.rs 75.00% 2 Missing ⚠️
tailcall-aws-lambda/src/runtime.rs 0.00% 1 Missing ⚠️
tailcall-cloudflare/src/runtime.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
- Coverage   83.77%   82.74%   -1.04%     
==========================================
  Files         198      183      -15     
  Lines       19379    18287    -1092     
==========================================
- Hits        16235    15131    -1104     
- Misses       3144     3156      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webbdays webbdays force-pushed the 1271 branch 2 times, most recently from f7ab336 to f9669b7 Compare May 10, 2024 03:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 12, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 12, 2024
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented May 15, 2024

@webbdays Can you please resolve the conflicts.

@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented May 15, 2024

Whenever you are ready, just mark it as ready to review.

@tusharmath tusharmath marked this pull request as draft May 15, 2024 12:15
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 15, 2024
@webbdays
Copy link
Copy Markdown
Contributor Author

webbdays commented May 16, 2024

ok.

@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 16, 2024
@webbdays webbdays marked this pull request as ready for review May 17, 2024 03:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 17, 2024 •
edited
Loading

🐰Bencher

ReportSun, June 2, 2024 at 15:47:50 UTC
Projecttailcall
Branch1863/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
group_by✅ (view plot)543.54 (-7.19%)651.86 (83.38%)
input/args.missing✅ (view plot)22.80 (-6.45%)27.23 (83.74%)
input/args.nested.existing✅ (view plot)42.11 (-15.13%)64.69 (65.09%)
input/args.nested.missing✅ (view plot)38.35 (+0.18%)40.67 (94.31%)
input/args.root✅ (view plot)38.05 (-17.39%)61.46 (61.91%)
input/headers.existing✅ (view plot)30.38 (-4.31%)33.64 (90.30%)
input/headers.missing✅ (view plot)29.13 (-5.33%)33.49 (86.98%)
input/value.missing✅ (view plot)23.17 (-1.31%)25.10 (92.32%)
input/value.nested.existing✅ (view plot)40.66 (-2.16%)44.90 (90.57%)
input/value.nested.missing✅ (view plot)37.71 (+3.33%)38.44 (98.09%)
input/value.root✅ (view plot)37.85 (-1.07%)41.56 (91.07%)
input/vars.existing✅ (view plot)7.43 (-7.22%)9.01 (82.48%)
input/vars.missing✅ (view plot)12.01 (+31.50%)12.28 (97.77%)
test_batched_body✅ (view plot)2,623.10 (-99.60%)2,394,111.82 (0.11%)
test_batched_body #2✅ (view plot)1,719,000.00 (+0.23%)1,855,417.04 (92.65%)
test_data_loader✅ (view plot)478,900.00 (+1.84%)488,616.64 (98.01%)
test_handle_request✅ (view plot)154,240.00 (-3.97%)179,882.69 (85.74%)
test_http_execute_method✅ (view plot)18,274.00 (-0.29%)19,520.41 (93.61%)
with_mustache_expressions✅ (view plot)1,161.80 (-0.69%)1,235.32 (94.05%)
with_mustache_literal✅ (view plot)727.35 (+0.60%)770.48 (94.40%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

tusharmath
tusharmath reviewed May 18, 2024
View reviewed changes
tusharmath
tusharmath reviewed May 18, 2024
View reviewed changes
tusharmath
tusharmath reviewed May 18, 2024
View reviewed changes
tusharmath
tusharmath reviewed May 18, 2024
View reviewed changes
tusharmath
tusharmath reviewed May 18, 2024
View reviewed changes
tusharmath
tusharmath reviewed May 18, 2024
View reviewed changes
tusharmath
tusharmath reviewed May 18, 2024
View reviewed changes
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Jun 1, 2024

@webbdays I have made a few changes in the implementation. IF you could look at why the tests are failing, that would be great. I think overall it's ready to merge.

Thanks once again!

@tusharmath tusharmath marked this pull request as draft June 1, 2024 11:13
@webbdays
Copy link
Copy Markdown
Contributor Author

webbdays commented Jun 1, 2024

Ok. I will check that.

@webbdays webbdays marked this pull request as ready for review June 3, 2024 03:02
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 5, 2024

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 5, 2024
@tusharmath tusharmath enabled auto-merge (squash) June 7, 2024 07:11
@amitksingh1490 amitksingh1490 removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Jun 7, 2024
@tusharmath tusharmath disabled auto-merge June 7, 2024 08:10
@tusharmath tusharmath merged commit 09809bb into tailcallhq:main Jun 7, 2024
tusharmath added a commit that referenced this pull request Jun 7, 2024
@webbdays @tusharmath @amitksingh1490
feat: multiple onRequest handlers (#1863)
10948ea 
Co-authored-by: Tushar Mathur <tusharmath@gmail.com>
Co-authored-by: amit <amitksingh1490@gmail.com>
@algora-pbc algora-pbc bot mentioned this pull request Jun 15, 2024
Closed
@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Jun 15, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Jun 28, 2024

/approve

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Jun 28, 2024

@tusharmath: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Jul 1, 2024

Something is off on Algora so canceling your claim and giving you a tip instead.

/tip 250

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Jul 1, 2024

🎉🎈 @webbdays has been awarded $250! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tusharmath tusharmath tusharmath approved these changes

@amitksingh1490 amitksingh1490 amitksingh1490 approved these changes

Assignees

No one assigned

Labels

🙋 Bounty claim ci: benchmark Runs benchmarks 💰 Rewarded type: feature Brand new functionality, features, pages, workflows, endpoints, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: ability to configure request handler

3 participants

@webbdays @tusharmath @amitksingh1490