Conversation
|
Look great to me. @YuhanLiin, if this works for you, I'll release |
YuhanLiin
reviewed
Dec 6, 2022
| } | ||
| } | ||
|
|
||
| doc_comment! { |
There was a problem hiding this comment.
Why not use triple slashes for this comment?
Owner
Author
There was a problem hiding this comment.
If we want to stringify a macro metavariable using stringify!, we need to use the #[doc] attribute and string literal instead of the usual doc comment. In recent compilers (1.54+), #[doc = concat!(...)] also works, but in older compilers, a macro like this needs to be used.
|
Yeah everything looks good to me. |
YuhanLiin
approved these changes
Dec 6, 2022
Owner
Author
|
Thanks both of you for the review! bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 9, 2022
47: Add add/sub/and/or/xor methods that do not return previous value r=taiki-e a=taiki-e
This adds `Atomic{I,U}*::{add,sub,and,or,xor}` and `AtomicBool::{and,or,xor}` methods.
They are equivalent to the corresponding `fetch_*` methods, but do not return the previous value. They are intended for optimization on platforms that implement atomics using inline assembly, such as the MSP430.
Currently, optimizations by these methods (add,sub,and,or,xor) are only guaranteed for MSP430; on x86, LLVM can optimize in most cases, so cases, where this would improve things, should be rare.
See pftbest/msp430-atomic#7 for the context.
cc `@cr1901` `@YuhanLiin`
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Contributor
|
Timed out. |
Owner
Author
|
bors retry |
Contributor
Owner
Author
|
Published in 0.3.16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
Atomic{I,U}*::{add,sub,and,or,xor}andAtomicBool::{and,or,xor}methods.They are equivalent to the corresponding
fetch_*methods, but do not return the previous value. They are intended for optimization on platforms that implement atomics using inline assembly, such as the MSP430.Currently, optimizations by these methods (add,sub,and,or,xor) are only guaranteed for MSP430; on x86, LLVM can optimize in most cases, so cases, where this would improve things, should be rare.
See pftbest/msp430-atomic#7 for the context.
cc @cr1901 @YuhanLiin