Skip to content

Support #[project] attribute on 'let var = match' exressions#51

Merged
bors[bot] merged 1 commit intotaiki-e:masterfrom
Aaron1011:project-let-match
Aug 24, 2019
Merged

Support #[project] attribute on 'let var = match' exressions#51
bors[bot] merged 1 commit intotaiki-e:masterfrom
Aaron1011:project-let-match

Conversation

@Aaron1011
Copy link
Collaborator

Previously, the #[project] attribute would only apply to plain 'match'
expressions, not 'match' expressions immediately assigned to a local.

This commit checks for #[project] attributes in the initializer of a
'let' expression, if the initializer is a 'match' expression.

Previously, the #[project] attribute would only apply to plain 'match'
expressions, not 'match' expressions immediately assigned to a local.

This commit checks for #[project] attributes in the initializer of a
'let' expression, if the initializer is a 'match' expression.
@taiki-e
Copy link
Owner

taiki-e commented Aug 24, 2019

Thanks!

bors r+

bors bot added a commit that referenced this pull request Aug 24, 2019
51: Support #[project] attribute on 'let var = match' exressions r=taiki-e a=Aaron1011

Previously, the #[project] attribute would only apply to plain 'match'
expressions, not 'match' expressions immediately assigned to a local.

This commit checks for #[project] attributes in the initializer of a
'let' expression, if the initializer is a 'match' expression.

Co-authored-by: Aaron Hill <aa1ronham@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 24, 2019

Build succeeded

  • taiki-e.pin-project

@bors bors bot merged commit 624d037 into taiki-e:master Aug 24, 2019
@taiki-e taiki-e added this to the v0.4 milestone Aug 24, 2019
@taiki-e taiki-e added the A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) label Sep 24, 2019
@taiki-e taiki-e mentioned this pull request Sep 25, 2019
bors bot added a commit that referenced this pull request Sep 25, 2019
109: Release 0.4.0 r=taiki-e a=taiki-e

cc #21

### Changes since the latest 0.3 release:

* **Pin projection has become a safe operation.** In the absence of other unsafe code that you write, it is impossible to cause undefined behavior. (#18)

* `#[unsafe_project]` attribute has been replaced with `#[pin_project]` attribute. (#18, #33)

* The `Unpin` argument has been removed - an `Unpin` impl is now generated by default. (#18)

* Drop impls must be specified with `#[pinned_drop]` instead of via a normal `Drop` impl. (#18, #33, #86)

* `Unpin` impls must be specified with an impl of `UnsafeUnpin`, instead of implementing the normal `Unpin` trait. (#18)

* `#[pin_project]` attribute now determines the visibility of the projection type/method is based on the original type. (#96)

* `#[pin_project]` can now be used for public type with private field types. (#53)

* `#[pin_project]` can now interoperate with `#[cfg()]`. (#77)

* Added `project_ref` method to `#[pin_project]` types. (#93)

* Added `#[project_ref]` attribute. (#93)

* Removed "project_attr" feature and always enable `#[project]` attribute. (#94)

* `#[project]` attribute can now be used for `impl` blocks. (#46)

* `#[project]` attribute can now be used for `use` statements. (#85)

* `#[project]` attribute now supports `match` expressions at the position of the initializer expression of `let` expressions. (#51)

### Changes since the 0.4.0-beta.1 release:

* Fixed an issue that caused an error when using `#[pin_project(UnsafeUnpin)]` and not providing a manual `UnsafeUnpin` implementation on a type with no generics or lifetime. (#107)


Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants