Conversation
Owner
Author
|
bors r+ |
Contributor
Build failed
|
Owner
Author
|
bors retry |
Contributor
Build succeeded
|
Contributor
|
This clearly does something complicated and subtle, but I have no idea what and how. :) Could the code (in the repo) be augmented with a detailed but explanation of what the generated code looks like and why all these funny quirks are needed, and why they are enough? As it is right now, a review of this crate seems near impossible. |
Owner
Author
|
@RalfJung Oh, sorry. I thought I added comments in #107, but it seems that I actually forgot. I will add it later. (Also, I left a comment in #102 (comment) about what this PR is doing.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the same as #107.
This fixes #102 completely.
cc #108