Sketch out support for matplotlibrc-like config dictionaries#4
Merged
tacaswell merged 4 commits intotacaswell:rcparam_ngfrom Jan 17, 2014
Merged
Sketch out support for matplotlibrc-like config dictionaries#4tacaswell merged 4 commits intotacaswell:rcparam_ngfrom
tacaswell merged 4 commits intotacaswell:rcparam_ngfrom
Conversation
tacaswell
added a commit
that referenced
this pull request
Jan 17, 2014
Sketch out support for matplotlibrc-like config dictionaries
Owner
|
Looks good to me! |
tacaswell
pushed a commit
that referenced
this pull request
Sep 9, 2015
MNT: use IPython's signature if needed + available
tacaswell
pushed a commit
that referenced
this pull request
Oct 1, 2017
This fixes some possible heap buffer overflows, such as the following
triggered by our cmmi10.ttf:
```
ERROR: AddressSanitizer: heap-buffer-overflow on address 0x617000235709 at pc 0x7f95efd3c48a bp 0x7ffe41b6ecc0 sp 0x7ffe41b6ecb0
READ of size 1 at 0x617000235709 thread T0
#0 0x7f95efd3c489 in utf16be_to_ascii extern/ttconv/pprdrv_tt.cpp:178
#1 0x7f95efd3c489 in Read_name(TTFONT*) extern/ttconv/pprdrv_tt.cpp:339
#2 0x7f95efd499ef in read_font(...) extern/ttconv/pprdrv_tt.cpp:1325
#3 0x7f95efd4c602 in get_pdf_charprocs(...) extern/ttconv/pprdrv_tt.cpp:1420
#4 0x7f95efd35c22 in py_get_pdf_charprocs src/_ttconv.cpp:217
0x617000235709 is located 1 bytes to the right of 648-byte region [0x617000235480,0x617000235708)
allocated by thread T0 here:
#0 0x7f9612262a38 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xdea38)
#1 0x7f95efd3b261 in GetTable(TTFONT*, char const*) extern/ttconv/pprdrv_tt.cpp:140
```
tacaswell
pushed a commit
that referenced
this pull request
Mar 31, 2023
uses the assert_almost_equal function instead of assert_array_equal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tacaswell I ended up moving
RcParamNGtoMPLConfigjust for kicks. Other than that, the only substantive changes is thefrom_user_configmethod and a fix for old-style classes (contour.ContourSetbroke thetypecheck).The rest of the code sits alongside yours and adds parsing for dictionaries that look similar to what you might get out of matplotlibrc files. Right now, only 'lines.linewidth' is connected.