Add background job warnings & warn about auto-detect failures #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct job failure from a fatal exception to a warning
Contributor
|
OMG, @mcharters. You're one of the few —ouside the core team— that was brave enough to dive into the deep dark corners of Tabula's innards. Thanks a lot. Please give me a couple days to review your PR. Thanks again! |
Contributor
Author
|
No problem! I've been using a modified version of Tabula for our team to do document processing, so I'm happy to try to contribute to the project where I can. The tool has been a big help for us! |
jazzido
added a commit
that referenced
this pull request
Dec 10, 2015
Add background job warnings & warn about auto-detect failures
jeremybmerrill
pushed a commit
that referenced
this pull request
Jun 26, 2018
Add background job warnings & warn about auto-detect failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when the table auto-detect job failed, it would stop users from trying to manually select tables from the document, even though having that job fail doesn't necessarily mean tables can't be extracted from the file.
I added warnings to background jobs, and changed the auto-detect job so that if an exception is thrown in tabula-java then the job completes with a warning instead of a general failure.
I also modified the web app to display warnings returned by the file upload process.