Introduce dynamic return type for the get_approved_comments function#211
Merged
szepeviktor merged 1 commit intoszepeviktor:masterfrom Feb 23, 2024
lipemat:feature/get_approved_comments
Merged
Introduce dynamic return type for the get_approved_comments function#211szepeviktor merged 1 commit intoszepeviktor:masterfrom lipemat:feature/get_approved_comments
get_approved_comments function#211szepeviktor merged 1 commit intoszepeviktor:masterfrom
lipemat:feature/get_approved_comments
Conversation
`get_approved_comments` changes the return type based on value within the pass $args parameter. - Return 'WP_Comment[]' by default. - Return `int[]` if `$fields = 'ids'`. - Return `int` if `$count = true`.
lipemat
added a commit
to lipemat/phpstan-wordpress
that referenced
this pull request
Feb 23, 2024
szepeviktor
reviewed
Feb 23, 2024
Owner
|
Thank you. |
lipemat
added a commit
to lipemat/phpstan-wordpress
that referenced
this pull request
Mar 22, 2024
The pull request was merged upstream. szepeviktor/phpstan-wordpress#211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_approved_commentschanges the return type based on value within the passed $args parameter.int[]if$fields = 'ids'.intif$count = true.https://developer.wordpress.org/reference/functions/get_approved_comments/#return