nspawn: hash the machine name, when looking for a suitable UID base #7437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "-U" is used we look for a UID range we can use for our container. We start with the UID the tree is already assigned to, and if that didn't work we'd pick random ranges so far. With this change we'll first try to hash a suitable range from the container name, and use that if it works, in order to make UID assignments more likely to be stable. This follows a similar logic PID 1 follows when using DynamicUser=1.
7970710 to
6929d75
Compare
Member
Author
|
CI failure due to #7440. Everything else passed. Merging. |
Member
Author
|
Ah, wait, not merging, nobody reviewed this yet..... |
angdraug
added a commit
to angdraug/systemd
that referenced
this pull request
Dec 23, 2020
Explicitly document the behavior introduced in systemd#7437: when picking a new UID shift base with "-U", a hash of the machine name will be tried before falling back to fully random UID base candidates.
bluca
pushed a commit
that referenced
this pull request
Dec 23, 2020
Explicitly document the behavior introduced in #7437: when picking a new UID shift base with "-U", a hash of the machine name will be tried before falling back to fully random UID base candidates.
mikhailnov
pushed a commit
to mikhailnov/systemd
that referenced
this pull request
Apr 23, 2021
Explicitly document the behavior introduced in systemd#7437: when picking a new UID shift base with "-U", a hash of the machine name will be tried before falling back to fully random UID base candidates. (cherry picked from commit 68709a6) (cherry picked from commit 4032a13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "-U" is used we look for a UID range we can use for our container.
We start with the UID the tree is already assigned to, and if that
didn't work we'd pick random ranges so far. With this change we'll first
try to hash a suitable range from the container name, and use that if it
works, in order to make UID assignments more likely to be stable.
This follows a similar logic PID 1 follows when using DynamicUser=1.