Skip to content

firstboot: fix segfault when --locale-messages= is passed without --locale= #25253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yuwata merged 1 commit into from
Nov 4, 2022
Merged

firstboot: fix segfault when --locale-messages= is passed without --locale= #25253

yuwata merged 1 commit into from
Nov 4, 2022

Conversation

@bluca
Copy link
Member

@bluca bluca commented Nov 4, 2022 

\#0  __strcmp_evex () at ../sysdeps/x86_64/multiarch/strcmp-evex.S:295 No locals.
\#1  0x0000557444eb172b in process_locale () at ../src/firstboot/firstboot.c:342
        etc_localeconf = 0x7ffd40217b80 "/root/root/etc/locale.conf"
        locales = {0x0, 0x0, 0x0}
        i = 0
        r = <optimized out>
        __PRETTY_FUNCTION__ = "process_locale"
        __func__ = "process_locale"
\#2  0x0000557444eaff93 in run (argv=0x7ffd40217d98, argc=3) at ../src/firstboot/firstboot.c:1401
        loop_device = 0x0
        unlink_dir = 0x0
        r = <optimized out>
        loop_device = <optimized out>
        unlink_dir = <optimized out>
        r = <optimized out>
        __func__ = <optimized out>
        __PRETTY_FUNCTION__ = <optimized out>
        enabled = <optimized out>
        _error = <optimized out>
        _level = <optimized out>
        _e = <optimized out>
        _level = <optimized out>
        _e = <optimized out>
\#3  main (argc=3, argv=0x7ffd40217d98) at ../src/firstboot/firstboot.c:1432
        r = <optimized out>
        __PRETTY_FUNCTION__ = "main"

Fixes #25249

@bluca
firstboot: fix segfault when --locale-messages= is passed without --l…
0f237ad 
…ocale=

\#0  __strcmp_evex () at ../sysdeps/x86_64/multiarch/strcmp-evex.S:295
No locals.
\#1  0x0000557444eb172b in process_locale () at ../src/firstboot/firstboot.c:342
        etc_localeconf = 0x7ffd40217b80 "/root/root/etc/locale.conf"
        locales = {0x0, 0x0, 0x0}
        i = 0
        r = <optimized out>
        __PRETTY_FUNCTION__ = "process_locale"
        __func__ = "process_locale"
\#2  0x0000557444eaff93 in run (argv=0x7ffd40217d98, argc=3) at ../src/firstboot/firstboot.c:1401
        loop_device = 0x0
        unlink_dir = 0x0
        r = <optimized out>
        loop_device = <optimized out>
        unlink_dir = <optimized out>
        r = <optimized out>
        __func__ = <optimized out>
        __PRETTY_FUNCTION__ = <optimized out>
        enabled = <optimized out>
        _error = <optimized out>
        _level = <optimized out>
        _e = <optimized out>
        _level = <optimized out>
        _e = <optimized out>
\#3  main (argc=3, argv=0x7ffd40217d98) at ../src/firstboot/firstboot.c:1432
        r = <optimized out>
        __PRETTY_FUNCTION__ = "main"

Fixes systemd#25249
@yuwata yuwata added the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Nov 4, 2022
@yuwata yuwata merged commit 4c4a73c into systemd:main Nov 4, 2022
@bluca bluca deleted the firstbork branch November 4, 2022 09:09
mrc0mmand added a commit to mrc0mmand/systemd that referenced this pull request Nov 6, 2022
@mrc0mmand
test: re-enable skipped systemd-firstboot --locale-messages= test
59377db 
Since the original issue should be resolved by systemd#25253.
@keszybz keszybz removed good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed needs-stable-backport labels Nov 24, 2022
eworm-de pushed a commit to eworm-de/systemd that referenced this pull request Feb 4, 2023
@mrc0mmand @keszybz
test: re-enable skipped systemd-firstboot --locale-messages= test
ddc1898 
Since the original issue should be resolved by systemd#25253.

(cherry picked from commit 59377db)
d-hatayama pushed a commit to d-hatayama/systemd that referenced this pull request Feb 15, 2023
@mrc0mmand @d-hatayama
test: re-enable skipped systemd-firstboot --locale-messages= test
2b40b82 
Since the original issue should be resolved by systemd#25253.
valentindavid pushed a commit to valentindavid/systemd that referenced this pull request Aug 8, 2023
@mrc0mmand @bluca
test: re-enable skipped systemd-firstboot --locale-messages= test
26fdfb0 
Since the original issue should be resolved by systemd#25253.

(cherry picked from commit 59377db)
(cherry picked from commit ddc1898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuwata yuwata yuwata approved these changes

Assignees

No one assigned

Labels

firstboot

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

systemd-firstboot: segfault when using --locale-messages=xxx without --locale=yyy

3 participants

@bluca @yuwata @keszybz