Skip to content

Fix bad errno checks #15868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
poettering merged 2 commits into from
May 20, 2020
Merged

Fix bad errno checks #15868

poettering merged 2 commits into from
May 20, 2020

Conversation

@keszybz
Copy link
Member

@keszybz keszybz commented May 20, 2020

No description provided.

@keszybz keszybz mentioned this pull request May 20, 2020
Closed
@poettering
Copy link
Member

poettering commented May 20, 2020

ouch ouch ouch

stuff for coccinelle?

@poettering poettering added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed tree-wide labels May 20, 2020
@poettering poettering linked an issue May 20, 2020 that may be closed by this pull request
Failed to fix up PID1 environment #15730
Closed
@poettering poettering merged commit 0c789b6 into systemd:master May 20, 2020
@keszybz keszybz deleted the fix-failed-to-fix-up-pid1-environment branch May 21, 2020 06:11
@keszybz keszybz removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label May 21, 2020
@keszybz
Copy link
Member Author

keszybz commented May 21, 2020

I used grep... cocinelle or coverity of lgtm or whatever would be nice. I wonder why this wasn't caught before. (Or maybe some of those cases where gcc was insisting that we're using unitialized values were that?).

mrc0mmand added a commit to mrc0mmand/systemd that referenced this pull request Oct 7, 2020
@mrc0mmand
coccinelle: check for invalid errno comparisons
b7776b7 
Prompted by systemd#15868
@mrc0mmand mrc0mmand mentioned this pull request Oct 7, 2020
Merged
mrc0mmand added a commit to mrc0mmand/systemd that referenced this pull request Oct 8, 2020
@mrc0mmand
coccinelle: check for invalid errno comparisons
d0bbc63 
Prompted by systemd#15868
mrc0mmand added a commit to mrc0mmand/systemd that referenced this pull request Oct 9, 2020
@mrc0mmand
coccinelle: check for invalid errno comparisons
c915be1 
Prompted by systemd#15868
mrc0mmand added a commit to mrc0mmand/systemd that referenced this pull request Oct 9, 2020
@mrc0mmand
coccinelle: check for invalid errno comparisons
7e97526 
Prompted by systemd#15868
lqb pushed a commit to lqb/systemd that referenced this pull request Oct 29, 2020
@mrc0mmand @lqb
coccinelle: check for invalid errno comparisons
ce375ad 
Prompted by systemd#15868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tree-wide

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to fix up PID1 environment

2 participants

@keszybz @poettering