networkd: don't remove ip address or route #10597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuwata
requested changes
Nov 2, 2018
yuwata
reviewed
Nov 2, 2018
239c8a4 to
2245d5b
Compare
poettering
reviewed
Nov 5, 2018
2245d5b to
3af0203
Compare
Contributor
Author
|
I addressed the comments above, please have a look. I did not yet cover the routes so far. |
poettering
requested changes
Nov 6, 2018
Member
poettering
left a comment
There was a problem hiding this comment.
looks good, just some minor coding style nitpicks
3af0203 to
fbfdeb0
Compare
In case networkd is restarted this prevents a removal of an already existing IP address that would be configured using networkd. With the proposed changes the IP address will be kept on the interface without removing. This happens only on physical hosts or VMs since networkd handles interface configuration slightly different in containers.
fbfdeb0 to
30226d2
Compare
In case networkd is restarted this prevents a removal of an already existing route that would be configured using networkd. With the proposed changes the route will be kept on the interface without removing. This happens only on physical hosts or VMs since networkd handles interface configuration slightly different in containers.
Contributor
Author
|
Added a commit to solve the same issue wrt. static routes. |
Member
|
looks excellent! thanks! |
poettering
approved these changes
Nov 6, 2018
Contributor
Author
|
Thanks for reviewing! |
keszybz
pushed a commit
to systemd/systemd-stable
that referenced
this pull request
Jan 11, 2019
In case networkd is restarted this prevents a removal of an already existing IP address that would be configured using networkd. With the proposed changes the IP address will be kept on the interface without removing. This happens only on physical hosts or VMs since networkd handles interface configuration slightly different in containers. cherry picked from systemd/systemd#10597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case networkd is restarted this prevents a removal of an already existing IP
address that would be configured using networkd. With the proposed changes the
IP address will be kept on the interface without removing. This happens only on
physical hosts or VMs since networkd handles interface configuration slightly
different in containers.