util: check overflow in parse_time() and parse_nsec() #10493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
reviewed
Oct 23, 2018
| something = true; | ||
|
|
||
|
|
||
| k = ((usec_t) -1) / multiplier; |
Member
There was a problem hiding this comment.
USEC_INFINITY instead of `((usec_t) -1) might be prettier, dunno
Contributor
|
How do you do that? How do you fix overflows faster than I type all those 1's? :-) There is certainly not enough coffee for me to keep up with you :-) Thank you! |
facebook-github-bot
pushed a commit
to facebookarchive/rpm-backports
that referenced
this pull request
Dec 11, 2018
Summary: Rebase two fixes onto the version merged upstream: systemd/systemd#10507 systemd/systemd#10567 and backport a few more: systemd/systemd#10411 systemd/systemd#10493 systemd/systemd#10757 systemd/systemd#10876 These are almost all cgroup2 related. Reviewed By: cdown Differential Revision: D13351498 fbshipit-source-id: 87c8428d48dbb0eb2ae7d34f7381fff88f83872f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #10411 (comment).
cc @evverx.