Conversation
Summary of ChangesHello @mirostauder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating several key external dependencies to their latest stable versions for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
There was a problem hiding this comment.
Code Review
This pull request upgrades several dependencies. The changes primarily involve updating Makefiles to accommodate new versions, handle new sub-dependencies, and remove patches that are no longer necessary. I've identified two critical issues that are likely to break the build: a potential typo in the specified curl version and a broken build recipe for clickhouse-cpp. The other changes appear to be correct and align with the dependency upgrade goals.
| cd clickhouse-cpp/clickhouse-cpp && cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo . | ||
| cd clickhouse-cpp/clickhouse-cpp && CC=${CC} CXX=${CXX} ${MAKE} |
There was a problem hiding this comment.
The build recipe for clickhouse-cpp appears to be broken. The ln -fs clickhouse-cpp-*/ clickhouse-cpp command was removed in this pull request, but the subsequent commands still try to cd into a clickhouse-cpp directory. Since the tar command extracts into a versioned directory (e.g., clickhouse-cpp-2.6.0), and the symlink is no longer created, the cd clickhouse-cpp/clickhouse-cpp command will fail.
To fix this, you can modify the build commands to use a wildcard to cd into the versioned directory.
cd clickhouse-cpp/clickhouse-cpp-*/ && cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo .
cd clickhouse-cpp/clickhouse-cpp-*/ && CC=${CC} CXX=${CXX} ${MAKE}
merge of proposed deps upgrades for v3.0.3
already merged in v3.0 with PR #5138:
libconfig to v1.8.1
postgresql to v16.10
libmicrohttpd to v1.0.2
sqlite3 to v3.50.4
clickhouse to v2.6.0
curl to v8.16.0
based on this branch in separate PR
json to v3.12.0