Conversation
Summary of ChangesHello @mirostauder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for building on Fedora 42, addressing the necessary compatibility adjustments for its updated GCC compiler. The changes involve updating several core dependencies, applying specific patches to resolve compiler-related issues, and integrating the new build targets into the existing build system and Docker Compose configurations. The primary goal is to ensure the project can be successfully built and tested on the latest Fedora release. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for Fedora 42 builds. The changes include updating dependencies like libconfig to v1.8.1 and postgresql to 16.10, and patching mariadb-client to resolve a compiler issue with the bool keyword. Build configurations in Makefiles and docker-compose.yml are updated accordingly. The changes are logical and directly support the goal of enabling Fedora 42 builds. I have one suggestion to improve the maintainability of the docker-compose.yml file by reducing duplication.
| fedora42_build: | ||
| extends: | ||
| service: _build | ||
| image: proxysql/packaging:build-fedora42-v3.0.2 | ||
| volumes: | ||
| - ./docker/images/proxysql/rhel-compliant/rpmmacros/rpmbuild/:/root/rpmbuild/ | ||
| - ./docker/images/proxysql/rhel-compliant/rpmmacros/.rpmmacros:/root/.rpmmacros | ||
| - ./docker/images/proxysql/rhel-compliant/entrypoint/:/opt/entrypoint/ | ||
| - ./:/opt/proxysql/ | ||
| environment: | ||
| - PKG_RELEASE=fedora42 | ||
| - PROXYSQL_BUILD_TYPE=clickhouse |
There was a problem hiding this comment.
While the new fedora42_build service is consistent with the existing Fedora build services, it adds to the duplication in this file. The volumes section is identical for fedora40_build, fedora41_build, and the new fedora42_build.
To improve maintainability and make it easier to add new Fedora versions in the future, consider creating a common base service for Fedora builds that contains the shared properties. For example:
_fedora_build_base:
extends:
service: _build
volumes:
- ./docker/images/proxysql/rhel-compliant/rpmmacros/rpmbuild/:/root/rpmbuild/
- ./docker/images/proxysql/rhel-compliant/rpmmacros/.rpmmacros:/root/.rpmmacros
- ./docker/images/proxysql/rhel-compliant/entrypoint/:/opt/entrypoint/
- ./:/opt/proxysql/Then, each specific Fedora build service can extend this base, reducing repetition:
fedora42_build:
extends:
service: _fedora_build_base
image: proxysql/packaging:build-fedora42-v3.0.2
environment:
- PKG_RELEASE=fedora42
- PROXYSQL_BUILD_TYPE=clickhouseThis refactoring could be applied to the other Fedora build services as well.
|
adds fedora42 builds
due to new GCC compiler, some issues need to be solved:
fix by updating libconfig to v1.8.1
patch mariadb-client - bool is a keyword
fix by updating postgresql to 16.10
add explicit include in btree.h