V3.0.3 add centos10 and almalinux10 builds#5139
Conversation
Summary of ChangesHello @mirostauder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the project's build matrix by introducing support for CentOS 10, AlmaLinux 10, and Fedora 42. It also includes crucial dependency updates and build system modernizations, such as upgrading libconfig and switching its build to CMake, and applying a compatibility patch for the MariaDB client library to work with newer compilers. These changes ensure broader platform compatibility and maintainability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds build support for CentOS 10, AlmaLinux 10, and Fedora 42. The changes include updating the main Makefile with new build targets, adding corresponding services to docker-compose.yml, and applying necessary patches and dependency updates to support newer compilers and libraries in these distributions.
The changes are logical and consistent with the goal of the pull request. I have one suggestion regarding the docker-compose.yml file to improve its maintainability by reducing code duplication.
| centos10_build: | ||
| extends: | ||
| service: _build | ||
| image: proxysql/packaging:build-centos10-v3.0.2 | ||
| volumes: | ||
| - ./docker/images/proxysql/rhel-compliant/rpmmacros/rpmbuild/:/root/rpmbuild/ | ||
| - ./docker/images/proxysql/rhel-compliant/rpmmacros/.rpmmacros:/root/.rpmmacros | ||
| - ./docker/images/proxysql/rhel-compliant/entrypoint/:/opt/entrypoint/ | ||
| - ./:/opt/proxysql/ | ||
| environment: | ||
| - PKG_RELEASE=centos10 | ||
| - PROXYSQL_BUILD_TYPE=clickhouse |
There was a problem hiding this comment.
This file has a lot of duplication, especially in the volumes sections for RHEL-compliant builds (CentOS, Fedora, AlmaLinux). This makes the file unnecessarily long and harder to maintain.
You could significantly reduce this duplication by using YAML anchors. For example, you could define the common volumes once and then reuse them.
Here's an example of how you could refactor it:
x-rhel-volumes: &rhel-volumes
- ./docker/images/proxysql/rhel-compliant/rpmmacros/rpmbuild/:/root/rpmbuild/
- ./docker/images/proxysql/rhel-compliant/rpmmacros/.rpmmacros:/root/.rpmmacros
- ./docker/images/proxysql/rhel-compliant/entrypoint/:/opt/entrypoint/
- ./:/opt/proxysql/
services:
# ...
centos10_build:
extends:
service: _build
image: proxysql/packaging:build-centos10-v3.0.2
volumes: *rhel-volumes
environment:
- PKG_RELEASE=centos10
- PROXYSQL_BUILD_TYPE=clickhouse
# ... and so on for other rhel-compliant buildsApplying this pattern would make the file much cleaner and easier to manage as you add more build targets.
|
builds on top of PR #5138
adds centos10 builds
adds almalinux10 builds