Merged
Conversation
Contributor
renecannao
commented
Feb 6, 2025
- replaced DELETE with ORDER BY
- changed status variable name (naming convention) pmm 2 client proxysql_exporter fails #4820
SQLite amalgamation doesn't support DELETE with ORDER BY . Thus the DELETE with ORDER BY was replaced by a SELECT to retrieve the maximum id, followed by a DELETE up to that id.
This should fix issue #4280
This was referenced Jan 24, 2025
3 tasks
renecannao
added a commit
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.