Fix halt on 'PROXYSQL RESUME' command#4757
Merged
renecannao merged 3 commits intov2.7from Nov 26, 2024
Merged
Conversation
During a RESUME operation, if a 'MySQL_Thread' is bootstrapping listeners (in `MySQL_Thread::run_BootstrapListener`) and detect that `MySQL_Threads_Handler::bootstrapping_listeners` is 'false', the thread prematurely shuts down its own bootstrapping flag from 'mypolls' (`ProxySQL_Poll::bootstrapping_listeners`). Since this thread wont ever bootstrap its corresponding listening sockets, the other working threads will be stalled waiting on it, eventually triggering the watchdog and crashing the instance. Since the bootstrapping operation is sequential, it's expected that all the threads but the one starting their listening sockets are in an active wait. A sensible delay has been introduced to reduce the overhead of such wait.
Since the operation of stopping each worker thread listeners is performed during 'maintenance_loops', the active wait taking place in 'listener_del' is likely to take some time. A sensible delay has been added to reduce unneccesary load.
2f353e9 to
8774b31
Compare
This is a follow-up of commit #19c8f8698
renecannao
added a commit
that referenced
this pull request
Nov 26, 2024
Fix halt on 'PROXYSQL RESUME' command - Port of #4757
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
During a
RESUMEoperation, if a 'MySQL_Thread' is bootstrapping listeners (inMySQL_Thread::run_BootstrapListener) and detect thatMySQL_Threads_Handler::bootstrapping_listenersis 'false', the thread prematurely shuts down its own bootstrapping flag from 'mypolls' (ProxySQL_Poll::bootstrapping_listeners). Since this thread wont ever bootstrap its corresponding listening sockets, the other working threads will be stalled waiting on it, eventually triggering the watchdog and crashing the instance.Solution
Simplified the logic using a unique flag for bootstrapping (
MySQL_Threads_Handler::bootstrapping_listeners) and introduced a sensible delay to reduce the potential overhead of the worker threads busy-waiting for its time to start their listening sockets, as well as the counterpart overhead on theAdminthread while performing thePAUSEoperation.