Skip to content

work on refactoring and documentation of ECS#943

Merged
synfinatic merged 2 commits intomainfrom
ecs-refactor
Jul 8, 2024
Merged

work on refactoring and documentation of ECS#943
synfinatic merged 2 commits intomainfrom
ecs-refactor

Conversation

@synfinatic
Copy link
Owner

Fixes: #938

@codecov
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (ecba0f2) to head (2954a98).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
+ Coverage   83.90%   83.91%   +0.01%     
==========================================
  Files          41       41              
  Lines        3013     3014       +1     
==========================================
+ Hits         2528     2529       +1     
  Misses        392      392              
  Partials       93       93              
Flag Coverage Δ
unittests 83.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/ecs/client/client.go 92.86% <100.00%> (ø)
internal/ecs/server/server.go 92.77% <100.00%> (+0.09%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecba0f2...2954a98. Read the comment docs.

@synfinatic synfinatic force-pushed the ecs-refactor branch 3 times, most recently from 4b5b45e to 9c02e64 Compare July 7, 2024 02:17
@synfinatic synfinatic force-pushed the ecs-refactor branch 2 times, most recently from 2048b81 to db7011e Compare July 7, 2024 21:15
@synfinatic synfinatic merged commit 4cbdcc5 into main Jul 8, 2024
@synfinatic synfinatic deleted the ecs-refactor branch July 8, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor/document ecs commands in the command reference

1 participant