chore(proto): change symlinktarget to be byte sequence (fixes #9913) #9914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings in protobuf must be utf-8, and we enforce that explicitly or implicitly in most places, but not really in symlink targets. Symlinks can target things outside of synced folders and we have no authority to decide what the encoding of that filename is, so allow it as an uninterpreted byte sequence. This is wire- and database compatible with the existing definition.
acolomb
approved these changes
Jan 10, 2025
calmh
added a commit
that referenced
this pull request
Mar 10, 2025
* main: (25 commits) refactor(api): make shutdown timeout configurable for tests (#9980) refactor(api): deduplicate HTTP test helpers and allow session cookie access (#9977) build: correct API call for Weblate statistics build(deps): update dependencies (#9978) chore(etc): remove /usr/bin prefix from Linux .desktop files (#9966) build: use Go 1.24, minimum is Go 1.23 (#9960) fix(policy): do not require multiple maintainers for build changes chore(gui, man, authors): update docs, translations, and contributors chore(fs): build kqueue instead of fsevents watcher on iOS (#9950) build(deps): update dependencies (#9951) refactor: using slices.Contains to simplify the code (#9918) build: switch to cloud code signing for Windows (#9948) chore(gui, man, authors): update docs, translations, and contributors chore(gui, man, authors): update docs, translations, and contributors fix(model): clarify errors on Windows user/group lookup (fixes #9929) (#9930) chore(gui, man, authors): update docs, translations, and contributors chore(scanner): don't warn about cancelled scan (#9920) chore(gui, man, authors): update docs, translations, and contributors chore(proto): change symlinktarget to be byte sequence (fixes #9913) (#9914) fix(api): don't crash requests after failing to unmarshal tokens (fixes #9909) (#9912) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings in protobuf must be utf-8, and we enforce that explicitly or implicitly in most places, but not really in symlink targets. Symlinks can target things outside of synced folders and we have no authority to decide what the encoding of that filename is, so allow it as an uninterpreted byte sequence.
This is wire- and database compatible with the existing definition.