ios: minimal set of changes for iOS app to work #9619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
OK I now managed to actually add the history properly. This now shows a ton of commits (historical changes by Simon Pickup which do not all end up in this branch). The final set of changes ('files changed') however is quite small. Let me know if something else is preferred. |
calmh
reviewed
Jul 29, 2024
Member
calmh
left a comment
There was a problem hiding this comment.
Apart from the notes below, seems fine to me.
Contributor
Author
|
Some formatting to fix it seems in setpriority_noop, as well as a test: |
Member
|
The tests fail due to auto-generted mocks that need regenerating due to the newly exported method: |
calmh
approved these changes
Jul 31, 2024
pixelspark
added a commit
to pixelspark/sushitrain
that referenced
this pull request
Jul 31, 2024
imsodin
reviewed
Aug 1, 2024
Closed
imsodin
pushed a commit
that referenced
this pull request
Aug 11, 2024
### Purpose Wrap access to Model for users that use the syncthing Go package. See discussion: #9619 (review) ### Testing It works with the iOS app. Other than that, there are no current users of this API (to my knowledge) as Model was only exposed recently form the iOS app.
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Aug 19, 2024
* main: (46 commits) build: use Go 1.23, require minimum 1.22 (syncthing#9651) gui, man, authors: Update docs, translations, and contributors lib/fs: Put the caseFS as the outermost layer (syncthing#9648) gui: Add Irish (ga) translation template (syncthing#9646) gui, man, authors: Update docs, translations, and contributors lib/syncthing: Add wrapper for access to model (syncthing#9627) cli: Remove `go-shlex` dependency (syncthing#9644) lib/sha256: Remove it (syncthing#9643) build: Update dependencies (syncthing#9640) Chmod -x non-executable files (fixes syncthing#9629) (syncthing#9630) gui, man, authors: Update docs, translations, and contributors all: minimal set of changes for iOS app (syncthing#9619) gui, man, authors: Update docs, translations, and contributors gui, man, authors: Update docs, translations, and contributors etc: Remove restart on suspend systemd service (ref syncthing#8448) (syncthing#9611) gui, man, authors: Update docs, translations, and contributors lib/fs: Add missing locks to fakeFile methods (fixes syncthing#9499) (syncthing#9603) lib/api: Increase test request timeout (fixes syncthing#9455) (syncthing#9602) gui, man, authors: Update docs, translations, and contributors lib/ignore: Remove unused patterns in cache (syncthing#9601) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR contains the set of changes needed to make Syncthing work on iOS for my iOS app for Syncthing.
Most changes originate from the Mobius Sync fork. I have removed the changes from their fork that are not strictly needed for my app (i.e. their changes to the GUI and command line utilities, for instance) and squashed it all in a single commit.
In summary, the changes are:
RequestGlobalandPullerProgresspublic symbolsI would very much appreciate these changes to be (eventually) merged to mainline syncthing, as this would allow my iOS app to track the mainline source code directly and removes the need (for me at least) for maintaining a separate fork. Perhaps the Mobius folks can also benefit from this (although as noted this branch does not contain their changes to e.g. the GUI).
Testing
This branch has been tested with the iOS app and appears to work fine. The full set of MobiusSync changes has been used before with success.
Screenshots
n/a
Documentation
There should be no visible changes for users due to this set of changes.
Authorship
The AUTHORS file contains changes to add my name and Simon Pickup (@sjpickup), who as authored the Mobius changes. Due to the squashing of the changes, his commits and hence his name have disappeared from commit metadata (I couldn't figure out a way to preserve the history correctly here in Git...)