Skip to content

Conversation

@Ratio2
Copy link
Contributor

@Ratio2 Ratio2 commented Oct 2, 2022

No description provided.

@Ratio2 Ratio2 changed the title gui: Fix rescan interval on auto accepted encrypted folder (fixes #8… gui: Fix rescan interval on auto accepted encrypted folder (fixes #8572) Oct 2, 2022
@Ratio2 Ratio2 force-pushed the fix-rescan-interval-auto branch from 7410527 to 29e79f0 Compare October 2, 2022 17:22
@Ratio2 Ratio2 changed the title gui: Fix rescan interval on auto accepted encrypted folder (fixes #8572) lib/model: Fix rescan interval on auto accepted encrypted folder (fixes #8572) Oct 2, 2022
@acolomb acolomb linked an issue Oct 3, 2022 that may be closed by this pull request
@Ratio2 Ratio2 force-pushed the fix-rescan-interval-auto branch from f4fe85d to bd036d9 Compare October 4, 2022 12:33
Copy link
Member

@calmh calmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to let it be zero if it's zero?

@Ratio2
Copy link
Contributor Author

Ratio2 commented Nov 3, 2022

I didn't understand your question, but please see a more detailed description of the change:
#8572 (comment)

@imsodin
Copy link
Member

imsodin commented Dec 21, 2022

Why do we want to let it be zero if it's zero?

I didn't understand your question, but please see a more detailed description of the change:
#8572 (comment)

I believe that's the answer to the question (if I got it right):

  1. Scan interval 0 - we use 0, since there is no point in scanning an encrypted folder if we do not scan a regular folder

@imsodin imsodin changed the title lib/model: Fix rescan interval on auto accepted encrypted folder (fixes #8572) lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes #8572) Dec 21, 2022
@imsodin imsodin merged commit f9d6847 into syncthing:main Dec 21, 2022
calmh added a commit to calmh/syncthing that referenced this pull request Dec 21, 2022
* upstream/main:
  lib/fs: Watching is unsupported on android/amd64 (fixes syncthing#8709) (syncthing#8710)
  lib/model: Only log at info level if setting change time fails (syncthing#8725)
  lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes syncthing#8572) (syncthing#8573)
  gui, man, authors: Update docs, translations, and contributors
  gui: Remove unmaintained language variant nl-BE (syncthing#8722)
  gui, script: Fix indentation in lang-en.json to match others (syncthing#8721)
  docker: Ensure entrypoint is executable (syncthing#8719)
  Go 1.19.4
  Update dependencies (syncthing#8717)
  gui, man, authors: Update docs, translations, and contributors
@calmh calmh added this to the v1.22.3 milestone Dec 27, 2022
calmh added a commit to calmh/syncthing that referenced this pull request Jan 23, 2023
* main: (69 commits)
  Handle relay connect timeout (fixes syncthing#8749) (syncthing#8755)
  gui, man, authors: Update docs, translations, and contributors
  build: Go 1.19.5
  gui, man, authors: Update docs, translations, and contributors
  script: Add weblatedl.go for downloading updated translations (syncthing#8723)
  gui: Allow to translate action and type in Recent Changes modal (syncthing#8548)
  gui, man, authors: Update docs, translations, and contributors
  gui: Fix undefined lastSeenDays error in disconnected-inactive status check (ref syncthing#8530) (syncthing#8730)
  gui, man, authors: Update docs, translations, and contributors
  gui, api: Indicate running under container (syncthing#8728)
  lib/fs: Use io/fs errors as recommended in std lib (syncthing#8726)
  build: Handle co-authors (ref syncthing#3744) (syncthing#8708)
  lib/fs: Watching is unsupported on android/amd64 (fixes syncthing#8709) (syncthing#8710)
  lib/model: Only log at info level if setting change time fails (syncthing#8725)
  lib/model: Don't lower rescan interval from default on auto accepted enc folder (fixes syncthing#8572) (syncthing#8573)
  gui, man, authors: Update docs, translations, and contributors
  gui: Remove unmaintained language variant nl-BE (syncthing#8722)
  gui, script: Fix indentation in lang-en.json to match others (syncthing#8721)
  docker: Ensure entrypoint is executable (syncthing#8719)
  Go 1.19.4
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Dec 22, 2023
@syncthing syncthing locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect rescan interval on auto accepted encrypted folder

4 participants