fix(beacon): skip point-to-point interfaces on Android #10504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bt90 <btom1990@googlemail.com>
Signed-off-by: bt90 <btom1990@googlemail.com>
bt90
commented
Dec 22, 2025
researchxxl
added a commit
to researchxxl/syncthing-android
that referenced
this pull request
Dec 23, 2025
authored by bt90 syncthing/syncthing#10504 intended to solve the huge battery drain while syncthing local discovery is turned on
|
I run a build of Synching-Fork with this change on my Pixel 8 with Android 16 since last night and I can confirm that this solves the battery draining issue. |
|
this seems to help the users of affected phones so would love to see this rc.2 =) |
Signed-off-by: bt90 <btom1990@googlemail.com>
Contributor
Author
|
Let's wrap this up in time for Christmas 🎅 🎁 |
calmh
approved these changes
Dec 23, 2025
Martchus
pushed a commit
to Martchus/syncthing
that referenced
this pull request
Dec 26, 2025
Martchus
added a commit
to Martchus/syncthingtray
that referenced
this pull request
Dec 26, 2025
Martchus
pushed a commit
to Martchus/syncthing
that referenced
this pull request
Jan 6, 2026
chenxiaolong
pushed a commit
to chenxiaolong/syncthing
that referenced
this pull request
Jan 7, 2026
chenxiaolong
added a commit
to chenxiaolong/BasicSync
that referenced
this pull request
Jan 7, 2026
This prevents the cellular interfaces from being used by the local discovery feature. Upstream PR: syncthing/syncthing#10504 Upstream commit: b7b494b7cfaba642cded88073999bdefee472332 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As proposed in https://forum.syncthing.net/t/syncthing-fork-v2-uses-far-too-much-battery-over-v1/25384/124?u=bt90, the cellular interfaces on Android devices should not be woken up by local discovery in order to preserve battery life. These interfaces are marked as point-to-point on Android, which sets them apart from regular local interfaces such as Wi-Fi. Another typical use case for P2P interfaces is a VPN, but these TUN interfaces usually don't support broadcast or multicast, so we're not breaking any existing functionality.
I also added an additional
FlagRunningcheck for the multicast listener. The group join can only be done by sending IGMP packets and I doubt this is going to work on an interface that's not running 😅Testing
researchxxl/syncthing-android#75 (comment)
https://forum.syncthing.net/t/syncthing-fork-v2-uses-far-too-much-battery-over-v1/25384/128?u=bt90
Authorship
Your name and email will be added automatically to the AUTHORS file
based on the commit metadata.