chore(cli): clean up generated usage strings for config commands (fixes #10462) #10463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Colomb <src@andre.colomb.de>
Signed-off-by: André Colomb <src@andre.colomb.de>
These were disabled by HideHelp, leading to an error message in every usage output. This way, the flags get documented as well. Signed-off-by: André Colomb <src@andre.colomb.de>
This applies only to the top-level command "syncthing cli config" itself. Signed-off-by: André Colomb <src@andre.colomb.de>
This catches all generated usage messages for the commands generated through recli. It is probably considered bad practice to override urfave/cli's global package variables though. Signed-off-by: André Colomb <src@andre.colomb.de>
f1fbfea to
67fbde6
Compare
Member
Author
|
A better overall approach might be to rework https://github.com/AudriusButkevicius/recli/ for direct integration with Kong. But that's currently above my capacity I suppose. |
Member
Author
|
Some more ideas for improvement:
|
Signed-off-by: André Colomb <src@andre.colomb.de>
Signed-off-by: André Colomb <src@andre.colomb.de>
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Nov 25, 2025
------------------------------------------------------------------------------------- zmusic.mk 59101ab757be25cd658c9dc7656f7c736dbf1014 # Version: Commits on Nov 24, 2025 ------------------------------------------------------------------------------------- Refactor: Implement CoreMIDI-side scheduling for macOS MIDI playback (#86) Refactored music_coremidi_mididevice.mm to leverage CoreMIDI's timestamp-based scheduling for improved timing accuracy. Changes include: - Replaced client-side timing logic with CoreMIDI's host time. - Updated PlayTick to calculate and use future MIDITimeStamp for events. - Refactored PlayerLoop to use a condition variable for synchronization instead of busy-waiting with usleep., ----------------------------------------------------------------------------------------------------- batocera-controlcenter.mk 75b97954fcde28c12b7de0a2efd3685970a158ee # Version: Commits on Nov 24, 2025 ----------------------------------------------------------------------------------------------------- Removed GtkLayerShell (unused, not available yet), -------------------------------------------------------------------------------------------------------- batocera-emulationstation.mk 82a4726b967ae09d8354853e93a945ec350d9c48 # Version: Commits on Nov 25, 2025 -------------------------------------------------------------------------------------------------------- Merge pull request #2015 from batocera-linux/callbcc call bcc, ------------------------------------------------------------------------------------------------ batocera-es-piboy.mk 82a4726b967ae09d8354853e93a945ec350d9c48 # Version: Commits on Nov 25, 2025 ------------------------------------------------------------------------------------------------ Merge pull request #2015 from batocera-linux/callbcc call bcc, --------------------------------------------------------------------------------------- amiberry.mk 70229be422fdec13908def6adcd1c5a62db534e5 # Version: Commits on Nov 25, 2025 --------------------------------------------------------------------------------------- Revert \enhancement: Merged latest updates from WinUAE\ This reverts commit 9e545eee4ae66cf286822b451a89561539ce38b4., -------------------------------------------------------------------------------------------- amiberry-lite.mk c2017ddd0c2850253abe34a9b0e1cae9a78ab33c # Version: Commits on Nov 25, 2025 -------------------------------------------------------------------------------------------- ci: update reported version to 5.9.1, ------------------------------------------------------------------------------------------ duckstation.mk 3b25e7b3ad93b23abaa019896eebb60137e021d7 # Version: Commits on Nov 24, 2025 ------------------------------------------------------------------------------------------ Qt: Use Close button in ControllerCustomSettingsDialog Consistency., ----------------------------------------------------------------------------------- eden.mk e63f71c787ab955b48950dc9414625e15dc0980c # Version: Commits on Nov 25, 2025 ----------------------------------------------------------------------------------- [android, qt] 16 bit debug knob set for quick development toggles (#3076) ---------------------------------------------------- pcsx2.mk v2.5.331 # Version: Commits on Nov 25, 2025 ---------------------------------------------------- - [GS/HW: Refactor StretchRect() to have single entry to renderer/reduce duplication.](PCSX2/pcsx2#13159) ------------------------------------------------------------------------------------- ppsspp.mk 9035485abfa2b446981c10896f77789bce4a029c # Version: Commits on Nov 25, 2025 ------------------------------------------------------------------------------------- Merge pull request #21041 from hrydgard/control-mappings-ui Fix touch controls and control mappings UI in portrait, ------------------------------------------------------------------------------------ rpcs3.mk 5a9083e4fc0bfb73b09c4c436d8f5e78f8c2702a # Version: Commits on Nov 24, 2025 ------------------------------------------------------------------------------------ rsx: Fix saw-tooth artifacts when using GPU deswizzle for small texel widths, ------------------------------------------------- vice.mk r45867 # Version: Commits on Nov 24, 2025 ------------------------------------------------- guard unistd.h includes by HAVA_UNISTD_H, patch by Carlo Bramini git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45867 379a1393-f5fb-40a0-bcee-ef074d9b53f7, ------------------------------------------------------------------------------------------- xenia-native.mk 529e10f128ea9acea5c77282e20a078ed1362828 # Version: Commits on Nov 24, 2025 ------------------------------------------------------------------------------------------- [XAM] Fixed license_mask config option not being applied to content (DLCs), ------------------------------------------------------------------------------------- ikemen.mk c99afde9cc627e024933513723e5c57bab26ebf0 # Version: Commits on Nov 25, 2025 ------------------------------------------------------------------------------------- Merge pull request #2907 from Eiton/Vulkan other: fix build error, --------------------------------------------------------------- ruffle.mk nightly-2025-11-25 # Version: Commits on Nov 25, 2025 --------------------------------------------------------------- ## What's Changed * chore: Update translations from Crowdin by @kjarosh in ruffle-rs/ruffle#22313 * avm2: Reformat more AS3 sources by @kjarosh in ruffle-rs/ruffle#22314 * core: Always enable kerning for device fonts by @kjarosh in ruffle-rs/ruffle#22250 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-11-22...nightly-2025-11-25, -------------------------------------------------------------------------------------- scummvm.mk 60a083ac9f98f260fa41bdf589410e6670c9a26d # Version: Commits on Nov 25, 2025 -------------------------------------------------------------------------------------- PRIVATE: Fix compiler warning, ------------------------------------------------------------------------------------ box64.mk 589d042c34d0d329d600d7abe9fe3cdd40f0e3f6 # Version: Commits on Nov 25, 2025 ------------------------------------------------------------------------------------ [TRACE] Reworked a bit how trace are written to files/console, --------------------------------------------------------------------------------------- corsixth.mk 6005581722b895d835b60a26f1f16cedd07c9aae # Version: Commits on Nov 24, 2025 --------------------------------------------------------------------------------------- Merge pull request #3118 from lewri/play_research_bg Enable sound in research policy, ------------------------------------------------------------------------------------------ devilutionx.mk f295e67b9f561a976983c6018e6bf3ef5bd61ef9 # Version: Commits on Nov 25, 2025 ------------------------------------------------------------------------------------------ Add multiplayer event logging, ------------------------------------------------------------------------------------------- jazz2-native.mk d21bd747fac623e10959a5da6e2b722ffde2eb69 # Version: Commits on Nov 25, 2025 ------------------------------------------------------------------------------------------- Merge branch 'master' of https://github.com/deathkiller/jazz2-native, ---------------------------------------------------------------------------------------- supertux2.mk 7ec3a7d8d26737339916677d341c53d1c00546bc # Version: Commits on Nov 25, 2025 ---------------------------------------------------------------------------------------- Improved Crusher's check for end of recovery (#3411) Check only relevant directions when checking for end of recovery. Fixes #3407, ------------------------------------------------------------ syncthing.mk v2.0.12-rc.1 # Version: Commits on Nov 25, 2025 ------------------------------------------------------------ ## Major changes in 2.0 - Database backend switched from LevelDB to SQLite. There is a migration on first launch which can be lengthy for larger setups. The new database is easier to understand and maintain and, hopefully, less buggy. - The logging format has changed to use structured log entries (a message plus several key-value pairs). Additionally, we can now control the log level per package, and a new log level WARNING has been inserted between INFO and ERROR (which was previously known as WARNING...). The INFO level has become more verbose, indicating the sync actions taken by Syncthing. A new command line flag `--log-level` sets the default log level for all packages, and the `STTRACE` environment variable and GUI has been updated to set log levels per package. The `--verbose` and `--logflags` command line options have been removed and will be ignored if given. - Deleted items are no longer kept forever in the database, instead they are forgotten after fifteen months. If your use case require deletes to take effect after more than a fifteen month delay, set the `--db-delete-retention-interval` command line option or corresponding environment variable to zero, or a longer time interval of your choosing. - Modernised command line options parsing. Old single-dash long options are no longer supported, e.g. `-home` must be given as `--home`. Some options have been renamed, others have become subcommands. All serve options are now also accepted as environment variables. See `syncthing --help` and `syncthing serve --help` for details. - Rolling hash detection of shifted data is no longer supported as this effectively never helped. Instead, scanning and syncing is faster and more efficient without it. - A \default folder\ is no longer created on first startup. - Multiple connections are now used by default between v2 devices. The new default value is to use three connections: one for index metadata and two for data exchange. - The following platforms unfortunately no longer get prebuilt binaries for download at syncthing.net and on GitHub, due to complexities related to cross compilation with SQLite: - dragonfly/amd64 - solaris/amd64 - linux/ppc64 - netbsd/* - openbsd/386 and openbsd/arm - windows/arm - The handling of conflict resolution involving deleted files has changed. A delete can now be the winning outcome of conflict resolution, resulting in the deleted file being moved to a conflict copy. This release is also available as: * APT repository: https://apt.syncthing.net/ * Docker image: `docker.io/syncthing/syncthing:2.0.12-rc.1` or `ghcr.io/syncthing/syncthing:2.0.12-rc.1` (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version) ## What's Changed ### Other * chore: update quic-go, adapt to lack of write tracking by @calmh in syncthing/syncthing#10456 * chore(cli): clean up generated usage strings for config commands (fixes #10462) by @acolomb in syncthing/syncthing#10463 **Full Changelog**: syncthing/syncthing@v2.0.11...v2.0.12-rc.1,
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Dec 3, 2025
------------------------------------------------------------------------------------- ppsspp.mk 0efae8fae18a6e5290f31fc27251e33e369cdc6f # Version: Commits on Dec 02, 2025 ------------------------------------------------------------------------------------- Merge pull request #21052 from falsepopsky/translations translation: update es_LA & es_ES, ------------------------------------------------------------------------------------ rpcs3.mk 3c747b377f8e7112cfe85ed3b2a8147a9946ca39 # Version: Commits on Dec 02, 2025 ------------------------------------------------------------------------------------ Qt: fix translation of update dialog if the language was changed between downloading the json and clicking on update, -------------------------------------------------------------------------------------- tsugaru.mk dc2671d5864970e8f467224313d3e6ca0326a0ca # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- Improved fidelity of FDC Seek command., ------------------------------------------------------------------------------------------- xenia-native.mk dd29365970e06a1e40b06714a8fed0fcfffbbd1d # Version: Commits on Dec 01, 2025 ------------------------------------------------------------------------------------------- [APU] Switched to New XMA decoder as default - Added codepath for \consume only\ pass. This should resolve constant clicking in Source engine games. - Added smaller performance improvements to decoder, --------------------------------------------------------------- ruffle.mk nightly-2025-12-02 # Version: Commits on Dec 02, 2025 --------------------------------------------------------------- ## What's Changed * chore: Run `npm audit fix` in `web` to fix security advisories by @torokati44 in ruffle-rs/ruffle#22383 * tests: Make `known_failure` more precise by @moulins in ruffle-rs/ruffle#22366 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-12-01...nightly-2025-12-02, -------------------------------------------------------------------------------------- scummvm.mk db31ebb24f2a07fe3020c80a02593166ec8e7b7b # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- BAGEL: METAGAME: Fix font size in notebook dialog, --------------------------------------------------------------------------------------- thextech.mk b4c0f0bce24682960ff9a971e2912abc1eadaddf # Version: Commits on Dec 02, 2025 --------------------------------------------------------------------------------------- macOS: Fixed an inability to make screenshots dir Unfortunately, the existing code just fails with the tilda begin on macOS, --------------------------------------------------------------------------------------------- deskpipro-case.mk cc1b2045231f2e4f5c93174c12dc8958bc300bfb # Version: Commits on Dec 02, 2025 --------------------------------------------------------------------------------------------- Update install-raspios-64bit.sh Update install-raspios-64bit.sh thanks Will 's tips (tech-n-code), -------------------------------------------------------------------------------------- aic8800.mk 80e7d448d9431f919860b3654f75500b06528c3f # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- fix: add fix-Lower-the-debugging-log-level.patch Signed-off-by: Feng Zhang <feng@radxa.com>, --------------------------------------------------------------------------------------- corsixth.mk 91d35f353b1759ad59e1c4e22d5c02b96d71485d # Version: Commits on Dec 02, 2025 --------------------------------------------------------------------------------------- Merge pull request #3153 from TheCycoONE/fix_ub_zero_memcopy Fix xmi write when called with an empty buffer, ---------------------------------------------------------------------------------------- openmohaa.mk 9168f32cdbb14b58d82cd70ffb3197895f82a0e3 # Version: Commits on Dec 01, 2025 ---------------------------------------------------------------------------------------- refactor(network): pack decimals based on the explicitly rounded value, ----------------------------------------------------------------------------------- rott.mk e34d9e976c8c904dd20f52363b82e681f881c13a # Version: Commits on Dec 02, 2025 ----------------------------------------------------------------------------------- disable player head tilting on landing, autoaim and falling (#131) * disable player head tilting on landing, autoaim and falling * adjust multiplicator, set normal horizon on mouselook switch, ---------------------------------------------------------------------------------- stk.mk 7df9411f5f4cd3f445fc65eb2740341baa76b57b # Version: Commits on Dec 01, 2025 ---------------------------------------------------------------------------------- Support setting the RTT scale via the command line, ---------------------------------------------------------------------------------------- supertux2.mk be106c73ebc02a6f5189b01f471aa9f77fc40398 # Version: Commits on Dec 02, 2025 ---------------------------------------------------------------------------------------- Merge pull request #3422 from SuperTux/toggle-fancy-effects opengl: Fancy effects setting, ------------------------------------------------ re2c.mk 4.3.1 # Version: Commits on Dec 01, 2025 ------------------------------------------------ See [release notes](https://re2c.org/releases/release_notes.html#release-4-3-1) for details., ------------------------------------------------------- syncthing.mk v2.0.12 # Version: Commits on Dec 02, 2025 ------------------------------------------------------- ## Major changes in 2.0 - Database backend switched from LevelDB to SQLite. There is a migration on first launch which can be lengthy for larger setups. The new database is easier to understand and maintain and, hopefully, less buggy. - The logging format has changed to use structured log entries (a message plus several key-value pairs). Additionally, we can now control the log level per package, and a new log level WARNING has been inserted between INFO and ERROR (which was previously known as WARNING...). The INFO level has become more verbose, indicating the sync actions taken by Syncthing. A new command line flag `--log-level` sets the default log level for all packages, and the `STTRACE` environment variable and GUI has been updated to set log levels per package. The `--verbose` and `--logflags` command line options have been removed and will be ignored if given. - Deleted items are no longer kept forever in the database, instead they are forgotten after fifteen months. If your use case require deletes to take effect after more than a fifteen month delay, set the `--db-delete-retention-interval` command line option or corresponding environment variable to zero, or a longer time interval of your choosing. - Modernised command line options parsing. Old single-dash long options are no longer supported, e.g. `-home` must be given as `--home`. Some options have been renamed, others have become subcommands. All serve options are now also accepted as environment variables. See `syncthing --help` and `syncthing serve --help` for details. - Rolling hash detection of shifted data is no longer supported as this effectively never helped. Instead, scanning and syncing is faster and more efficient without it. - A \default folder\ is no longer created on first startup. - Multiple connections are now used by default between v2 devices. The new default value is to use three connections: one for index metadata and two for data exchange. - The following platforms unfortunately no longer get prebuilt binaries for download at syncthing.net and on GitHub, due to complexities related to cross compilation with SQLite: - dragonfly/amd64 - solaris/amd64 - linux/ppc64 - netbsd/* - openbsd/386 and openbsd/arm - windows/arm - The handling of conflict resolution involving deleted files has changed. A delete can now be the winning outcome of conflict resolution, resulting in the deleted file being moved to a conflict copy. This release is also available as: * APT repository: https://apt.syncthing.net/ * Docker image: `docker.io/syncthing/syncthing:2.0.12` or `ghcr.io/syncthing/syncthing:2.0.12` (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version) ## What's Changed ### Other * chore: update quic-go, adapt to lack of write tracking by @calmh in syncthing/syncthing#10456 * chore(cli): clean up generated usage strings for config commands (fixes #10462) by @acolomb in syncthing/syncthing#10463 **Full Changelog**: syncthing/syncthing@v2.0.11...v2.0.12, ---------------------------------------------------------------------------------------- retroarch.mk 4d35ce17e50c10b0f185b9cd5f26a2076d1a0bf9 # Version: Commits on Dec 02, 2025 ---------------------------------------------------------------------------------------- Windows fill_pathname_parent_dir_name start slash correction, -------------------------------------------------------------------------------------- vkquake.mk 9eaae2941d7ff6839d0e8a5d5b90798080519666 # Version: Commits on Dec 02, 2025 -------------------------------------------------------------------------------------- MD3: Model-based naming, keep only 1 variant This is fallback for surface-based naming, keep only model_name.md3_S_X_Y.ext (0..S-1 surfaces, 0..X-1 skin, 0..Y-1 framgroup) with Legacy and MD5 style numberings, there are enough options as it is..., ----------------------------------------------------------------------------------------- sonic3-air.mk 651e8ceb3cdc0e51c736068cfe05b61eabc21379 # Version: Commits on Dec 01, 2025 ----------------------------------------------------------------------------------------- For Oxygen Engine app, use project-specific sub-folders in app data, ---------------------------------------------------------------------------------- trx.mk 1874da98c8eb53952199119989c34adf37b5be41 # Version: Commits on Dec 01, 2025 ---------------------------------------------------------------------------------- docs: update game-flow/Lua docs This adds various minor tweaks to the game flow and Lua documentation., ----------------------------------------------------------------------------------------------------- libretro-mame2003-plus.mk 198f6aa08c23afcea32821afaaa1938d4215df41 # Version: Commits on Dec 02, 2025 ----------------------------------------------------------------------------------------------------- Add files via upload, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk 0efae8fae18a6e5290f31fc27251e33e369cdc6f # Version: Commits on Dec 02, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #21052 from falsepopsky/translations translation: update es_LA & es_ES, ----------------------------------------------------------------------------------------------- libretro-scummvm.mk db31ebb24f2a07fe3020c80a02593166ec8e7b7b # Version: Commits on Dec 02, 2025 ----------------------------------------------------------------------------------------------- BAGEL: METAGAME: Fix font size in notebook dialog,
cre4ture
added a commit
to cre4ture/thingium
that referenced
this pull request
Dec 15, 2025
- Database backend switched from LevelDB to SQLite. There is a migration on first launch which can be lengthy for larger setups. The new database is easier to understand and maintain and, hopefully, less buggy. - The logging format has changed to use structured log entries (a message plus several key-value pairs). Additionally, we can now control the log level per package, and a new log level WARNING has been inserted between INFO and ERROR (which was previously known as WARNING...). The INFO level has become more verbose, indicating the sync actions taken by Syncthing. A new command line flag `--log-level` sets the default log level for all packages, and the `STTRACE` environment variable and GUI has been updated to set log levels per package. The `--verbose` and `--logflags` command line options have been removed and will be ignored if given. - Deleted items are no longer kept forever in the database, instead they are forgotten after fifteen months. If your use case require deletes to take effect after more than a fifteen month delay, set the `--db-delete-retention-interval` command line option or corresponding environment variable to zero, or a longer time interval of your choosing. - Modernised command line options parsing. Old single-dash long options are no longer supported, e.g. `-home` must be given as `--home`. Some options have been renamed, others have become subcommands. All serve options are now also accepted as environment variables. See `syncthing --help` and `syncthing serve --help` for details. - Rolling hash detection of shifted data is no longer supported as this effectively never helped. Instead, scanning and syncing is faster and more efficient without it. - A "default folder" is no longer created on first startup. - Multiple connections are now used by default between v2 devices. The new default value is to use three connections: one for index metadata and two for data exchange. - The following platforms unfortunately no longer get prebuilt binaries for download at syncthing.net and on GitHub, due to complexities related to cross compilation with SQLite: - dragonfly/amd64 - solaris/amd64 - linux/ppc64 - netbsd/* - openbsd/386 and openbsd/arm - windows/arm - The handling of conflict resolution involving deleted files has changed. A delete can now be the winning outcome of conflict resolution, resulting in the deleted file being moved to a conflict copy. This release is also available as: * APT repository: https://apt.syncthing.net/ * Docker image: `docker.io/syncthing/syncthing:2.0.12` or `ghcr.io/syncthing/syncthing:2.0.12` (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version) * chore: update quic-go, adapt to lack of write tracking by @calmh in syncthing#10456 * chore(cli): clean up generated usage strings for config commands (fixes syncthing#10462) by @acolomb in syncthing#10463 **Full Changelog**: syncthing/syncthing@v2.0.11...v2.0.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The parser for the
syncthing cli configsubcommand hierarchy usesurfave/cli(v1.xx) in combination with thereclipackage, in contrast to the Kong parser used otherwise. This leads to inconsistent and partially wrong usage messages.The urfave default message templates are adapted to mostly align with the Kong style. There is one caveat, I currently need to adjust the global package variables in
urfave/clito affect the templates for commands and subcommands. I tried to simply set theCustomHelpTemplatefield on the generated structures, but that strangely didn't have an effect. And it would need to be done recursively, so this part is a bit hacky but painless approach to get the desired effect.Therefore the last commit is still a bit WIP, open for discussion.
Testing
Call any sub-command below
syncthing cli configwith the--helpflag appended. For incomplete commands, it can be left out, as implied without further arguments.I compared it with the output of
syncthing cli show --helpfor example regarding the consistent output format.