chore(upnp): remove incorrect embedding of nat.Service (fixes #10426) #10428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#10426) Revert the embedding of `nat.Service` (which contains the mutex) within `IGDService`. That happened in syncthing#9010 and wasn't necessary/based on a misconception, see: syncthing#9010 (comment) Signed-off-by: Simon Frei <freisim93@gmail.com>
calmh
approved these changes
Oct 13, 2025
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Nov 1, 2025
------------------------------------------------------------------------------------------ dolphin-emu.mk c22a483431bcc40a18250985426e0ae0c27bfa5a # Version: Commits on Oct 26, 2025 ------------------------------------------------------------------------------------------ Merge pull request #14031 from TellowKrinkle/GlslangFix CMake: Fix bundled glslang, ----------------------------------------------------------------------------------- eden.mk c713d44c8873c29cce7d6d5203a6d5776893d892 # Version: Commits on Oct 27, 2025 ----------------------------------------------------------------------------------- [dynarmic, docs] Add support for DragonFly, shared mapping fallback to private, and update docs (#2829) ------------------------------------------------------------------------------------- hatari.mk a92f00147cecca322a0dcd833795624873f5cecf # Version: Commits on Oct 26, 2025 ------------------------------------------------------------------------------------- m68k-linux: update to v6.17 kernel (buggy) Adds \dead code elimination\ (experimental/expert) option, which is enabled in the supplied kernel config, as it reduces kernel size by 1/2MB. Kernel v6.16 regression fix will come only in v6.18 release, so this Linux kernel release can still be broken for m68k. Fix will be backported to v6.16 / v6.17 releases later though., -------------------------------------------------------------------------------------- openmsx.mk 87f1263cf40666ced2f7301f65e8f1ff384dcd1c # Version: Commits on Oct 26, 2025 -------------------------------------------------------------------------------------- Release cursor grab when openMSX is paused. Closes #1116., ------------------------------------------------------------------------------------- ppsspp.mk ff5264ffa5450ecf363fd97df57304e3c74e055b # Version: Commits on Oct 27, 2025 ------------------------------------------------------------------------------------- Merge pull request #20925 from hrydgard/demo-open-fix Wrong key for the ImConfig, --------------------------------------------------------------- ruffle.mk nightly-2025-10-27 # Version: Commits on Oct 27, 2025 --------------------------------------------------------------- ## What's Changed * avm1: Change `TDisplayObject::object1` to return `Option<Object>` by @moulins in ruffle-rs/ruffle#22025 * avm2: Improve ability of optimizer to remove obfuscation in code by @Lord-McSweeney in ruffle-rs/ruffle#21999 * desktop: Add an option to export Ruffle bundles by @kjarosh in ruffle-rs/ruffle#21994 * core: Rename `PLACED_BY_SCRIPT` to `PLACED_BY_AVM2_SCRIPT` by @kjarosh in ruffle-rs/ruffle#22044 * core: Support different types of arguments in `Array.splice` properly by @kjarosh in ruffle-rs/ruffle#22045 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-10-25...nightly-2025-10-27, ------------------------------------------------------------------------------------------- sdl12-compat.mk 20ab1608972b20f872fbe1b3647ac09b59f38654 # Version: Commits on Oct 26, 2025 ------------------------------------------------------------------------------------------- Added GitHub release workflow, --------------------------------------------------------------------------------------- corsixth.mk 3946f1a5c75369f7f7079e45454b1d407245e1e7 # Version: Commits on Oct 27, 2025 --------------------------------------------------------------------------------------- Merge pull request #3103 from sraaronrock/master Update Spanish translation, ------------------------------------------------------------------------------------------ devilutionx.mk 442bbf5a944b6658f1457e4b6410f17140ea3a6a # Version: Commits on Oct 27, 2025 ------------------------------------------------------------------------------------------ Check if Android device has a file browser when importing data, ------------------------------------------------------------------------------------------- jazz2-native.mk 326ace94d96cda81b724abb338b39450d5198ee2 # Version: Commits on Oct 26, 2025 ------------------------------------------------------------------------------------------- Minor changes, ---------------------------------------------------------------------------------------- openmohaa.mk b06857d0774eabf5f910fc440983eb8c1cf28787 # Version: Commits on Oct 26, 2025 ---------------------------------------------------------------------------------------- fix(fgame): add more checks for weapon dropping (#815) - Drop carryable turrets, even if they are items. - Don’t drop weapons when dead. - In single-player mode, only allow dropping when realism mode is enabled., ------------------------------------------------------------ syncthing.mk v2.0.11-rc.1 # Version: Commits on Oct 27, 2025 ------------------------------------------------------------ ## Major changes in 2.0 - Database backend switched from LevelDB to SQLite. There is a migration on first launch which can be lengthy for larger setups. The new database is easier to understand and maintain and, hopefully, less buggy. - The logging format has changed to use structured log entries (a message plus several key-value pairs). Additionally, we can now control the log level per package, and a new log level WARNING has been inserted between INFO and ERROR (which was previously known as WARNING...). The INFO level has become more verbose, indicating the sync actions taken by Syncthing. A new command line flag `--log-level` sets the default log level for all packages, and the `STTRACE` environment variable and GUI has been updated to set log levels per package. The `--verbose` and `--logflags` command line options have been removed and will be ignored if given. - Deleted items are no longer kept forever in the database, instead they are forgotten after fifteen months. If your use case require deletes to take effect after more than a fifteen month delay, set the `--db-delete-retention-interval` command line option or corresponding environment variable to zero, or a longer time interval of your choosing. - Modernised command line options parsing. Old single-dash long options are no longer supported, e.g. `-home` must be given as `--home`. Some options have been renamed, others have become subcommands. All serve options are now also accepted as environment variables. See `syncthing --help` and `syncthing serve --help` for details. - Rolling hash detection of shifted data is no longer supported as this effectively never helped. Instead, scanning and syncing is faster and more efficient without it. - A \default folder\ is no longer created on first startup. - Multiple connections are now used by default between v2 devices. The new default value is to use three connections: one for index metadata and two for data exchange. - The following platforms unfortunately no longer get prebuilt binaries for download at syncthing.net and on GitHub, due to complexities related to cross compilation with SQLite: - dragonfly/amd64 - solaris/amd64 - linux/ppc64 - netbsd/* - openbsd/386 and openbsd/arm - windows/arm - The handling of conflict resolution involving deleted files has changed. A delete can now be the winning outcome of conflict resolution, resulting in the deleted file being moved to a conflict copy. This release is also available as: * APT repository: https://apt.syncthing.net/ * Docker image: `docker.io/syncthing/syncthing:2.0.11-rc.1` or `ghcr.io/syncthing/syncthing:2.0.11-rc.1` (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version) ## What's Changed ### Fixes * fix(policy): only allow approvals by non-author contributors by @marbens-arch in syncthing/syncthing#10419 * fix(fs): store `getExpireAdd` mutex in `caseCache` (fixes #9836) by @marbens-arch in syncthing/syncthing#10430 * fix(fs): apply case option to fakefs in casefs tests by @marbens-arch in syncthing/syncthing#10439 * fix(fs): only apply case option to fakefs in stress test by @marbens-arch in syncthing/syncthing#10440 ### Other * docs(docker): make host network mode the default by @bt90 in syncthing/syncthing#10416 * chore(upnp): remove incorrect embedding of nat.Service (fixes #10426) by @imsodin in syncthing/syncthing#10428 * chore: minor lint fixes by @calmh in syncthing/syncthing#10436 * chore(gui): add Azerbaijani (az) and Kurdish (ckb) l10n templates. by @acolomb in syncthing/syncthing#10442 **Full Changelog**: syncthing/syncthing@v2.0.10...v2.0.11-rc.1, ---------------------------------------------------------------------------------------- doomretro.mk 1a345a8fa9de5ddd3df73ab546d496f5d6b662bc # Version: Commits on Oct 27, 2025 ---------------------------------------------------------------------------------------- Bring back console warning if ShellExecuteEx() fails, ----------------------------------------------------------------------------------- tr1x.mk e60adaff5223be25cc36c4e528947bfc4c10b70a # Version: Commits on Oct 26, 2025 ----------------------------------------------------------------------------------- option/stats: merge to trx, ----------------------------------------------------------------------------------- tr2x.mk e60adaff5223be25cc36c4e528947bfc4c10b70a # Version: Commits on Oct 26, 2025 ----------------------------------------------------------------------------------- option/stats: merge to trx, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk ff5264ffa5450ecf363fd97df57304e3c74e055b # Version: Commits on Oct 27, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #20925 from hrydgard/demo-open-fix Wrong key for the ImConfig, -------------------------------------------------------------------------------------------- slang-shaders.mk fc381bfec1a694838b924862fe094cb32811be49 # Version: Commits on Oct 26, 2025 -------------------------------------------------------------------------------------------- Update ntsc_module_XL (#766) * Update ntsc_module_XL.slang * Add files via upload,
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Nov 9, 2025
----------------------------------------------------------------------------------- ares.mk 35671b2f8dee508e01155f14b38a370528b281da # Version: Commits on Nov 04, 2025 ----------------------------------------------------------------------------------- ld: Fix some media info registers. Fixes JB Harold side changing., ---------------------------------------------------------------------------------- clk.mk 0332bb4f12f707a19e06d00774257dc2d4970d48 # Version: Commits on Nov 04, 2025 ---------------------------------------------------------------------------------- Merge pull request #1624 from TomHarte/ArchimedesVideoTiming Pull clock divider inside the loop., ------------------------------------------------------------------------------------------ duckstation.mk a5e20511d969d4499591088f7d86eefac8d0dbd7 # Version: Commits on Nov 04, 2025 ------------------------------------------------------------------------------------------ Update the Simplified-Chinese Translation. (#3606), ----------------------------------------------------------------------------------- eden.mk 4bf2e0a7aa1c466ab98e6dfc9972c039345cc927 # Version: Commits on Nov 04, 2025 ----------------------------------------------------------------------------------- [dynarmic] Add a formatter for `Dynarmic::IR::Opcode` (#2948) ------------------------------------------------------------------------------------- hatari.mk 4df48fe4ceae69a21930a815e525941eb06f9a1c # Version: Commits on Nov 03, 2025 ------------------------------------------------------------------------------------- Fix str.c assert, ----------------------------------------------------------------------------------- play.mk 77c62d3a942e219bc9d072b4800fa0881208ce2a # Version: Commits on Nov 03, 2025 ----------------------------------------------------------------------------------- Fix some issues with recoil server not shutting down properly., ------------------------------------------------------------------------------------- ppsspp.mk 607451fe6a5322b030757cf54e855c9470af96b0 # Version: Commits on Nov 04, 2025 ------------------------------------------------------------------------------------- Merge pull request #20961 from hrydgard/misc-code-cleanup Misc code cleanup, -------------------------------------------------------------------------------------- shadps4.mk 683e5f3b0462f91cc7a80c6f688d5b83e51f32be # Version: Commits on Nov 04, 2025 -------------------------------------------------------------------------------------- Core: Simulate write-only file access with read-write access (#3360) * Swap write access mode for read write Opening with access mode w will erase the opened file. We do not want this. * Create mode Opening with write access was previously the only way to create a file through open, so add a separate FileAccessMode that uses the write access mode to create files. * Update file_system.cpp Remove a hack added to posix_rename to bypass the file clearing behaviors of FileAccessMode::Write * Check access mode in read functions Write-only files cause the EBADF return on the various read functions. Now that we're opening files differently, properly handling this is necessary. * Separate appends into proper modes Fixes a potential regression from one of my prior PRs, and ensures the Write | Append flag combo also behaves properly in read-related functions. * Move IsWriteOnly check after device/socket reads file->f is only valid for files, so checking this before checking for sockets/devices will cause access violations. * Fix issues Now that Write is identical to ReadWrite, internal uses of Write need to be swapped to my new Create mode * Fix remaining uses of FileAccessMode write to create files Missed these before. * Fix rebase * Add stubbed get_authinfo (#3722) * mostly stubbed get_authinfo * Return value observed on console if get_authinfo was called for the current thread, esrch otherwise --------- Co-authored-by: kalaposfos13 <153381648+kalaposfos13@users.noreply.github.com> Co-authored-by: georgemoralis <giorgosmrls@gmail.com>, ------------------------------------------------- vice.mk r45815 # Version: Commits on Nov 03, 2025 ------------------------------------------------- fix warning git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45815 379a1393-f5fb-40a0-bcee-ef074d9b53f7, ------------------------------------------------------------------------------------------- xenia-native.mk efa0a8bb395a16d2457b8d07d8d50951ad12a873 # Version: Commits on Oct 31, 2025 ------------------------------------------------------------------------------------------- [XBDM] Added sketchy implementation of DmPMCGetCounterName and DmPMCInstallAndStart, ----------------------------------------------------------------------------------- ymir.mk 472f287ea239e6572871538a6664c9feba02b499 # Version: Commits on Nov 03, 2025 ----------------------------------------------------------------------------------- chore: Add categories to some CHANGELOG entries, ------------------------------------------------------------------------------------- ikemen.mk be61dcdca44a43af41d32f92e390cec0a298b5be # Version: Commits on Nov 04, 2025 ------------------------------------------------------------------------------------- Merge pull request #2861 from rakieldev/newstuff refactor: migrate AIR indices to int32, --------------------------------------------------------------- ruffle.mk nightly-2025-11-04 # Version: Commits on Nov 04, 2025 --------------------------------------------------------------- ## What's Changed * tests: Deduplicate tests with multiple FP versions by @moulins in ruffle-rs/ruffle#22121 * avm1: Implement Sound.id3 by @kjarosh in ruffle-rs/ruffle#22122 * avm1: Clean up use of BitmapData in BitmapData functions by @Dinnerbone in ruffle-rs/ruffle#22120 * core: Use same RNG algorithm as avmplus by @zjk261 in ruffle-rs/ruffle#21938 * build(deps): bump the cargo-minor group with 2 updates by @dependabot[bot] in ruffle-rs/ruffle#22135 ## New Contributors * @zjk261 made their first contribution in ruffle-rs/ruffle#21938 **Full Changelog**: ruffle-rs/ruffle@nightly-2025-11-03...nightly-2025-11-04, -------------------------------------------------------------------------------------- scummvm.mk c08ea1e6536c25353f6e7dda717cc174f116b4c7 # Version: Commits on Nov 04, 2025 -------------------------------------------------------------------------------------- I18N: Update translation (Italian) Currently translated at 100.0% (3056 of 3056 strings), --------------------------------------------------------------------------------------- thextech.mk fdff234f27d4a3d558f156db3bd7f66761e305c9 # Version: Commits on Nov 04, 2025 --------------------------------------------------------------------------------------- Update changelog.txt, ------------------------------------------------------------------------------------ box64.mk e6843dcb9ff8b3f889e4e60f495408d14ba48ae3 # Version: Commits on Nov 04, 2025 ------------------------------------------------------------------------------------ [CMAKE] Fix typo (#3122), ----------------------------------------------------------------------------------------- catacombgl.mk 1979244f3668630c25e3d5501d038cf9b4c89b85 # Version: Commits on Nov 03, 2025 ----------------------------------------------------------------------------------------- Set direction for actors loaded from DOS saved game, ---------------------------------------------------------------------------------------- openmohaa.mk f2c31e956e6045a566625bf804eb0ab539ca0f8d # Version: Commits on Nov 03, 2025 ---------------------------------------------------------------------------------------- fix(common): provide the delta time when executing console commands on dedicated servers This fixes an issue in which the `wait` command would prevent further commands from being executed afterward., ---------------------------------------------------------------------------------- stk.mk ceecb88822ed41f65242212de35cc7f3ff2088c7 # Version: Commits on Nov 04, 2025 ---------------------------------------------------------------------------------- Prefill textbox for options and grand prix renaming (#5557), ------------------------------------------------------- syncthing.mk v2.0.11 # Version: Commits on Nov 04, 2025 ------------------------------------------------------- ## Major changes in 2.0 - Database backend switched from LevelDB to SQLite. There is a migration on first launch which can be lengthy for larger setups. The new database is easier to understand and maintain and, hopefully, less buggy. - The logging format has changed to use structured log entries (a message plus several key-value pairs). Additionally, we can now control the log level per package, and a new log level WARNING has been inserted between INFO and ERROR (which was previously known as WARNING...). The INFO level has become more verbose, indicating the sync actions taken by Syncthing. A new command line flag `--log-level` sets the default log level for all packages, and the `STTRACE` environment variable and GUI has been updated to set log levels per package. The `--verbose` and `--logflags` command line options have been removed and will be ignored if given. - Deleted items are no longer kept forever in the database, instead they are forgotten after fifteen months. If your use case require deletes to take effect after more than a fifteen month delay, set the `--db-delete-retention-interval` command line option or corresponding environment variable to zero, or a longer time interval of your choosing. - Modernised command line options parsing. Old single-dash long options are no longer supported, e.g. `-home` must be given as `--home`. Some options have been renamed, others have become subcommands. All serve options are now also accepted as environment variables. See `syncthing --help` and `syncthing serve --help` for details. - Rolling hash detection of shifted data is no longer supported as this effectively never helped. Instead, scanning and syncing is faster and more efficient without it. - A \default folder\ is no longer created on first startup. - Multiple connections are now used by default between v2 devices. The new default value is to use three connections: one for index metadata and two for data exchange. - The following platforms unfortunately no longer get prebuilt binaries for download at syncthing.net and on GitHub, due to complexities related to cross compilation with SQLite: - dragonfly/amd64 - solaris/amd64 - linux/ppc64 - netbsd/* - openbsd/386 and openbsd/arm - windows/arm - The handling of conflict resolution involving deleted files has changed. A delete can now be the winning outcome of conflict resolution, resulting in the deleted file being moved to a conflict copy. This release is also available as: * APT repository: https://apt.syncthing.net/ * Docker image: `docker.io/syncthing/syncthing:2.0.11` or `ghcr.io/syncthing/syncthing:2.0.11` (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version) ## What's Changed ### Fixes * fix(policy): only allow approvals by non-author contributors by @marbens-arch in syncthing/syncthing#10419 * fix(fs): store `getExpireAdd` mutex in `caseCache` (fixes #9836) by @marbens-arch in syncthing/syncthing#10430 * fix(fs): apply case option to fakefs in casefs tests by @marbens-arch in syncthing/syncthing#10439 * fix(fs): only apply case option to fakefs in stress test by @marbens-arch in syncthing/syncthing#10440 ### Other * docs(docker): make host network mode the default by @bt90 in syncthing/syncthing#10416 * chore(upnp): remove incorrect embedding of nat.Service (fixes #10426) by @imsodin in syncthing/syncthing#10428 * chore: minor lint fixes by @calmh in syncthing/syncthing#10436 * chore(gui): add Azerbaijani (az) and Kurdish (ckb) l10n templates. by @acolomb in syncthing/syncthing#10442 **Full Changelog**: syncthing/syncthing@v2.0.10...v2.0.11, ----------------------------------------------------------------------------------------- winetricks.mk 533f41704766765cfb3706fb2aa197acbb05df32 # Version: Commits on Nov 04, 2025 ----------------------------------------------------------------------------------------- ev3: remove broken verb, ---------------------------------------------------------------------------------------------------- sdl2-gamecontrollerdb.mk 958e252520ece96cd1b03d5ff0d835db2f048991 # Version: Commits on Nov 04, 2025 ---------------------------------------------------------------------------------------------------- Upstream, sort, ---------------------------------------------------------------------------------------- retroarch.mk 081ced99408f18b1311eab48defb8d6efa5c0425 # Version: Commits on Nov 04, 2025 ---------------------------------------------------------------------------------------- Use hotkeys from core port 0 (#18353), ---------------------------------------------------------------------------------------- doomretro.mk 29aeae614094bfe8ddc9e3e2fe07b9c4b5db96ac # Version: Commits on Nov 04, 2025 ---------------------------------------------------------------------------------------- Update releasenotes.md, ------------------------------------------------------------------------------------- gzdoom.mk 5e9e2302f4c8193d227a5c5ddffc8ab8be4bb05d # Version: Commits on Nov 04, 2025 ------------------------------------------------------------------------------------- reverted the tooltip feature. In its current state it is not usable and causes errors and since it is bound to see no more updates it is better removed entirely., ---------------------------------------------------------------------------------- trx.mk 78f44fe41288ba8fe8f1f5e61eb25b554cc7a2bf # Version: Commits on Nov 04, 2025 ---------------------------------------------------------------------------------- tools/output-package-name: require arguments, --------------------------------------------------------------------------------------------------- libretro-dosbox-pure.mk e8cb6683e8539757644d84278cf4deb2b0d0debc # Version: Commits on Nov 04, 2025 --------------------------------------------------------------------------------------------------- Fix shut down menu item on standalone version with \Advanced > Start Menu\ set to the default, ------------------------------------------------------------------------------------------------------ libretro-doublecherrygb.mk 9bcde59b7a45171262f5589b3b303cecff79f4cd # Version: Commits on Nov 04, 2025 ------------------------------------------------------------------------------------------------------ 🚨fixed compiler warnings, -------------------------------------------------------------------------------------------------- libretro-gearcoleco.mk e2f85230c1b2d75697f7f5d49fe477f217a48952 # Version: Commits on Nov 03, 2025 -------------------------------------------------------------------------------------------------- Add VGM recorder, ------------------------------------------------------------------------------------------------- libretro-geargrafx.mk 89737b0eff46bcc56c2a7a486a1e833743cfe0f0 # Version: Commits on Nov 03, 2025 ------------------------------------------------------------------------------------------------- Minor typo, -------------------------------------------------------------------------------------------------- libretro-gearsystem.mk 572693112ca3a59525f4161bc0b25e7f632319ca # Version: Commits on Nov 03, 2025 -------------------------------------------------------------------------------------------------- Add VGM recorder. Fix #121, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk 607451fe6a5322b030757cf54e855c9470af96b0 # Version: Commits on Nov 04, 2025 ---------------------------------------------------------------------------------------------- Merge pull request #20961 from hrydgard/misc-code-cleanup Misc code cleanup, ----------------------------------------------------------------------------------------------- libretro-scummvm.mk c08ea1e6536c25353f6e7dda717cc174f116b4c7 # Version: Commits on Nov 04, 2025 ----------------------------------------------------------------------------------------------- I18N: Update translation (Italian) Currently translated at 100.0% (3056 of 3056 strings), --------------------------------------------------------------------------------------------- libretro-vba-m.mk d24fd6d47d8cdd3c3337dc0476e5b7eea5d4fe97 # Version: Commits on Nov 04, 2025 --------------------------------------------------------------------------------------------- translations: transifex pull Signed-off-by: Rafael Kitover <rkitover@gmail.com>,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the embedding of
nat.Service(which contains the mutex) withinIGDService. That happened in#9010 and wasn't necessary/based on a misconception, see:
#9010 (comment)
Signed-off-by: Simon Frei freisim93@gmail.com