-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix(model): correctly handle block-aligned empty sparse files #10332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsodin
approved these changes
Sep 1, 2025
Member
imsodin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be some kind of price for this (maybe an empty one) :D
Shablone
pushed a commit
to Shablone/syncthing_fork
that referenced
this pull request
Sep 1, 2025
…yncthing#10331) (syncthing#10332) When handling files that consist only of power-of-two-sized blocks of zero we'd know we have nothing to write, and when using sparse files we'd never even create the temp file. Hence the sync would fail. Signed-off-by: Jakob Borg <jakob@kastelo.net> Signed-off-by: Elias <1elias.bauer@gmail.com>
Shablone
pushed a commit
to Shablone/syncthing_fork
that referenced
this pull request
Sep 1, 2025
…yncthing#10331) (syncthing#10332) When handling files that consist only of power-of-two-sized blocks of zero we'd know we have nothing to write, and when using sparse files we'd never even create the temp file. Hence the sync would fail. Signed-off-by: Jakob Borg <jakob@kastelo.net> Signed-off-by: Elias <1elias.bauer@gmail.com>
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Sep 4, 2025
Since syncthing#10332 we'd create the temp file when closing out the puller state for a file, but this is inappropriate if the reason we're bailing out is that there isn't space for it to begin with. Instead, do the free space check before we even start copying/pulling. Signed-off-by: Jakob Borg <jakob@kastelo.net>
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Sep 4, 2025
Since syncthing#10332 we'd create the temp file when closing out the puller state for a file, but this is inappropriate if the reason we're bailing out is that there isn't space for it to begin with. Instead, do the free space check before we even start copying/pulling. Signed-off-by: Jakob Borg <jakob@kastelo.net>
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Sep 4, 2025
Since syncthing#10332 we'd create the temp file when closing out the puller state for a file, but this is inappropriate if the reason we're bailing out is that there isn't space for it to begin with. Instead, do the free space check before we even start copying/pulling. Signed-off-by: Jakob Borg <jakob@kastelo.net>
calmh
added a commit
that referenced
this pull request
Sep 4, 2025
Since #10332 we'd create the temp file when closing out the puller state for a file, but this is inappropriate if the reason we're bailing out is that there isn't space for it to begin with. Instead, do the free space check before we even start copying/pulling. Signed-off-by: Jakob Borg <jakob@kastelo.net>
Member
|
lol |
Hancock33
added a commit
to Hancock33/batocera.piboy
that referenced
this pull request
Sep 7, 2025
------------------------------------------------------------------------------------------------------
chromebook-linux-audio.mk 7f681e10e8b5352c4e468e901ee3770bfff37c40 # Version: Commits on Sept 02, 2025
------------------------------------------------------------------------------------------------------
functions: improve chrome platform detection
check for cros_ec in cases where stock firmware incorrectly reports system vendor,
-------------------------------------------------------------------------------------------
duckstation.mk 25b44f4283a347d05e221d841744bfd4c4d11c5f # Version: Commits on Sept 02, 2025
-------------------------------------------------------------------------------------------
Qt: Wire up new key glyphs,
--------------------------------------------------------------------------------------
ikemen.mk c00870fa97c057423c43459202476e25900ef993 # Version: Commits on Sept 01, 2025
--------------------------------------------------------------------------------------
Merge pull request #2612 from RakieI/newstuff
feat(motif): per player cursor.tween ;syntax fix,
------------------------------------------------------------------------------------------
lightspark.mk 2aee0d73e910ac51cbfe18dc92fe20cb19b93dc7 # Version: Commits on Sept 02, 2025
------------------------------------------------------------------------------------------
make getslot optimization work with local numbers
fixes crash in \FormulaRacer2012\ when entering \turbo\ mode during race,
---------------------------------------------------------------------------------------
openmsx.mk 19cde2fde4027c6df8fa6ca377e222638d81c2de # Version: Commits on Sept 02, 2025
---------------------------------------------------------------------------------------
VDPCmdEngine: tweak BD bit in S#2
Follow up on: 86abec73ab1ffaa
Thanks to 'hra1129' for more extended tests in:
openMSX/openMSX#1960,
-----------------------------------------------------
pcsx2.mk v2.5.150 # Version: Commits on Sept 02, 2025
-----------------------------------------------------
- [GameDB: Deadly Strike fixes](PCSX2/pcsx2#13226)
,
--------------------------------------------------------------------------------------
ppsspp.mk 0332e67ad40344696def0d3be4e00a88f2803f00 # Version: Commits on Sept 02, 2025
--------------------------------------------------------------------------------------
Merge pull request #20789 from hrydgard/more-modernization
Android: Fix some lint warnings,
-------------------------------------------------------------------------------------
rpcs3.mk c7de9053b4a5e0f02f4a5b9e13bb5643c70b8c53 # Version: Commits on Sept 01, 2025
-------------------------------------------------------------------------------------
Qt: fix saved gs_frame visibility,
----------------------------------------------------------------
ruffle.mk nightly-2025-09-02 # Version: Commits on Sept 02, 2025
----------------------------------------------------------------
## What's Changed
* chore: Fix a code comment by @n0samu in ruffle-rs/ruffle#21529
* avm2: Add call handlers to several error types by @SuchAFuriousDeath in ruffle-rs/ruffle#21524
**Full Changelog**: ruffle-rs/ruffle@nightly-2025-09-01...nightly-2025-09-02,
------------------------------------------------------
ryujinx.mk 1.3.129 # Version: Commits on Sept 02, 2025
------------------------------------------------------
Canary-1.3.129
---------------------------------------------------------------------------------------
shadps4.mk d9b4618085285b95d6d78deec7e0bd09a19e9dd2 # Version: Commits on Sept 02, 2025
---------------------------------------------------------------------------------------
Use icons, music and background images of updates if available (#3494)
* Update game_info.h
* fix clang game_info.h
* SceUpdateChecker game_info.h
* fix clang game_info.h
* fix clang(darn you space) game_info.h
* there was another space... game_info.h
* Update game_info.h
* fix clang game_info.h,
---------------------------------------------------------------------------------------
tsugaru.mk 4fe7012774fc3bcda9605c7a99878534a3cb0fdd # Version: Commits on Sept 02, 2025
---------------------------------------------------------------------------------------
Merge pull request #163 from bcc2528/master
Optimized sprite clear.,
------------------------------------------------------------------------------------
ymir.mk d4ee4651c654954bdd1f69f6a89d860c43b4360d # Version: Commits on Sept 02, 2025
------------------------------------------------------------------------------------
fix(VDP2): Fix VRAM access cycles loop ignoring banks A1, B0 and B1 if VRAM A wasn't partitioned
Fixes numerous graphics regressions,
----------------------------------------------------------
sdl3.mk release-3.2.22 # Version: Commits on Sept 01, 2025
----------------------------------------------------------
Updated to version 3.2.22 for release,
-------------------------------------------------------------------------------------
box64.mk 28d07f9bf03c76013db8d15477e8d1f46d1b930d # Version: Commits on Sept 02, 2025
-------------------------------------------------------------------------------------
[WRAPPERHELPER] Added legacy __attribute support (#2996),
-------------------------------------------------------------------------------------------
devilutionx.mk 0a21f6569c0e03b13de67cb7e2fe984c33253b53 # Version: Commits on Sept 02, 2025
-------------------------------------------------------------------------------------------
dos: Update SDL
Includes red cursor fix and protected mode interface performance
improvements.,
----------------------------------------------------------------------------------------
openjazz.mk a588027cc3706facb906a63d154b698f2529e0af # Version: Commits on Sept 02, 2025
----------------------------------------------------------------------------------------
Ci: Migrate to supported windows '22 runner,
-----------------------------------------------------------------------------------
stk.mk f654d88ff3dc3991d4a9596231f2be7c3c6df75f # Version: Commits on Sept 02, 2025
-----------------------------------------------------------------------------------
Fix wrong powerup sound when using after a rewind/forced sync (#5493)
Fix #5495,
-----------------------------------------------------------------------------------------
supertux2.mk 737777c810a9097aaea2c6270c34765f862beeed # Version: Commits on Sept 01, 2025
-----------------------------------------------------------------------------------------
fix tile error lol [ci skip],
-------------------------------------------------------
syncthing.mk v2.0.4 # Version: Commits on Sept 02, 2025
-------------------------------------------------------
## Major changes in 2.0
- Database backend switched from LevelDB to SQLite. There is a migration on
first launch which can be lengthy for larger setups. The new database is
easier to understand and maintain and, hopefully, less buggy.
- The logging format has changed to use structured log entries (a message
plus several key-value pairs). Additionally, we can now control the log
level per package, and a new log level WARNING has been inserted between
INFO and ERROR (which was previously known as WARNING...). The INFO level
has become more verbose, indicating the sync actions taken by Syncthing. A
new command line flag `--log-level` sets the default log level for all
packages, and the `STTRACE` environment variable and GUI has been updated
to set log levels per package. The `--verbose` and `--logflags` command
line options have been removed and will be ignored if given.
- Deleted items are no longer kept forever in the database, instead they are
forgotten after fifteen months. If your use case require deletes to take
effect after more than a fifteen month delay, set the
`--db-delete-retention-interval` command line option or corresponding
environment variable to zero, or a longer time interval of your choosing.
- Modernised command line options parsing. Old single-dash long options are
no longer supported, e.g. `-home` must be given as `--home`. Some options
have been renamed, others have become subcommands. All serve options are
now also accepted as environment variables. See `syncthing --help` and
`syncthing serve --help` for details.
- Rolling hash detection of shifted data is no longer supported as this
effectively never helped. Instead, scanning and syncing is faster and more
efficient without it.
- A \default folder\ is no longer created on first startup.
- Multiple connections are now used by default between v2 devices. The new
default value is to use three connections: one for index metadata and two
for data exchange.
- The following platforms unfortunately no longer get prebuilt binaries for
download at syncthing.net and on GitHub, due to complexities related to
cross compilation with SQLite:
- dragonfly/amd64
- illumos/amd64 and solaris/amd64
- linux/ppc64
- netbsd/*
- openbsd/386 and openbsd/arm
- windows/arm
- The handling of conflict resolution involving deleted files has changed. A
delete can now be the winning outcome of conflict resolution, resulting in
the deleted file being moved to a conflict copy.
This release is also available as:
* APT repository: https://apt.syncthing.net/
* Docker image: `docker.io/syncthing/syncthing:2.0.4` or `ghcr.io/syncthing/syncthing:2.0.4`
(`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version)
## What's Changed
### Fixes
* fix(cmd): only start temporary API server during migration if it's enabled by @pixelspark in syncthing/syncthing#10284
* fix(model): consider MaxFolderConcurrency when calculating number of hashers by @tomasz1986 in syncthing/syncthing#10285
* fix(model): consider number of CPU cores when calculating hashers on interactive OS (#10284) by @tomasz1986 in syncthing/syncthing#10286
* fix(db): apply all migrations and schema in one transaction by @calmh in syncthing/syncthing#10323
* fix(model): correctly handle block-aligned empty sparse files by @calmh in syncthing/syncthing#10332
* fix(syncthing): apply folder migrations with temporary API/GUI server by @calmh in syncthing/syncthing#10330
### Other
* chore(db): adjust db bench name to improve benchstat grouping by @imsodin in syncthing/syncthing#10283
* chore(db): cleanup DB in tests and remove OpenTemp by @imsodin in syncthing/syncthing#10282
* build: use Go 1.24 tools pattern by @calmh in syncthing/syncthing#10281
* chore(db): avoid rowid for blocks and blocklists by @bt90 in syncthing/syncthing#10315
* refactor(db): slightly improve insert performance by @calmh in syncthing/syncthing#10318
* chore(gui): use steps of 1024 KiB for bandwidth rate limits by @tomasz1986 in syncthing/syncthing#10316
* chore(gui): use step of 3600 for versions cleanup interval by @tomasz1986 in syncthing/syncthing#10317
* chore(db): benchmark output, migration blocks/s output by @calmh in syncthing/syncthing#10320
* chore(db): update schema version in the same transaction as migration by @imsodin in syncthing/syncthing#10321
* chore(db): migration for previous commits by @calmh in syncthing/syncthing#10319
**Full Changelog**: syncthing/syncthing@v2.0.3...v2.0.4,
-------------------------------------------------------
rgbds.mk v1.0.0-rc1 # Version: Commits on Sept 01, 2025
-------------------------------------------------------
Release v1.0.0-rc1,
-----------------------------------------------------------------------------------------
winetricks.mk 75118236ac5cb6f51918460a14f7bc40162a115e # Version: Commits on Aug 25, 2025
-----------------------------------------------------------------------------------------
fixed unicode quote.
SC1111 (warning): This is a unicode quote. Delete and retype it (or ignore/singlequote for literal).,
-----------------------------------------------------------------------------------------
retroarch.mk c32aa80ceac48405c5b3751f3e1fd4d4fae252a3 # Version: Commits on Sept 02, 2025
-----------------------------------------------------------------------------------------
Shader toggle cleanup,
-----------------------------------------------------------------------------------------
doomretro.mk d800779ed26430f155a635f9d583741355855b60 # Version: Commits on Sept 02, 2025
-----------------------------------------------------------------------------------------
Update to SDL v2.32.10,
--------------------------------------------------------------------------------------
gzdoom.mk b8807b7d996f3cef0e63736c7895b8c7cf1cbd40 # Version: Commits on Sept 01, 2025
--------------------------------------------------------------------------------------
Correct modeset timing on some systems
Co-authored-by: Marcus Minhorst <marcus.minhorst@gmail.com>,
-------------------------------------------------------------------------------------------
xash3d-fwgs.mk e38dc294114f29aced25966b7983c7bb4989f463 # Version: Commits on Sept 02, 2025
-------------------------------------------------------------------------------------------
3rdparty: mainui: update,
---------------------------------------------------------------------------------------------------
libretro-clownmdemu.mk 8dd1c9bb16a63c74a63c97deade671bb9d8b3d2c # Version: Commits on Sept 01, 2025
---------------------------------------------------------------------------------------------------
Fix CMake script failing on almost every libretro platform.,
-----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 0332e67ad40344696def0d3be4e00a88f2803f00 # Version: Commits on Sept 02, 2025
-----------------------------------------------------------------------------------------------
Merge pull request #20789 from hrydgard/more-modernization
Android: Fix some lint warnings,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling files that consist only of power-of-two-sized blocks of zero we'd know we have nothing to write, and when using sparse files we'd never even create the temp file. Hence the sync would fail.
Fixes #10331.