Merged
Conversation
stof
reviewed
Sep 2, 2024
| matrix: | ||
| os: [ubuntu-latest, windows-2019] | ||
| node-versions: ['18', '20', '21', '22'] | ||
| node-versions: ['18', '20', '22'] |
Member
Author
There was a problem hiding this comment.
Yes, but it looks like it will be available in ~october 2024, and I don't find anything in setup-node to use a dev version
Member
Author
There was a problem hiding this comment.
Let's merge, I've opened #1323 so we won't forget
af32edf to
a6b4e7a
Compare
a6b4e7a to
40ce3c9
Compare
Kocal
added a commit
to Kocal/webpack-encore
that referenced
this pull request
Sep 2, 2024
This PR was merged into the main branch. Discussion ---------- Drop support for Node.js 19 and 21 Due to the `>=18.0.0` version constraint in `engines.node`, it means that we allows Node.js 19 and 21, but, we don't want that. Odds versions are supported only 6 months, it only helps library maintainers to update their library comptability with a new Node.js LTS-version. You can see on https://nodejs.org/fr/about/previous-releases that Node.js 19 is not present and Node.js 21 support has been stopped around ~may 2024. Some of our dependencies explicitly does not support explicitly Node.js 19/21, like css-minimizer-webpack-plugin that [I've tried to upgrade to v5](https://github.com/symfony/webpack-encore/actions/runs/10654621974/job/29531168804?pr=1320): ``` yarn install v1.22.22 [1/5] Validating package.json... [2/5] Resolving packages... [3/5] Fetching packages... error cssnano@7.0.5: The engine "node" is incompatible with this module. Expected version "^18.12.0 || ^20.9.0 || >=22.0". Got "21.7.3" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. ``` Since we plan to release a new major version of Encore, it's the good moment. WDYT? Commits ------- 40ce3c9 Drop support for Node.js 19 and 21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the
>=18.0.0version constraint inengines.node, it means that we allows Node.js 19 and 21, but, we don't want that.Odds versions are supported only 6 months, it only helps library maintainers to update their library comptability with a new Node.js LTS-version. You can see on https://nodejs.org/fr/about/previous-releases that Node.js 19 is not present and Node.js 21 support has been stopped around ~may 2024.
Some of our dependencies explicitly does not support explicitly Node.js 19/21, like css-minimizer-webpack-plugin that I've tried to upgrade to v5:
Since we plan to release a new major version of Encore, it's the good moment.
WDYT?