Skip to content

Adding Asset Mapper support + new StimulusBundle#887

Merged
weaverryan merged 1 commit intosymfony:2.xfrom
weaverryan:asset-mapper-support
May 22, 2023
Merged

Adding Asset Mapper support + new StimulusBundle#887
weaverryan merged 1 commit intosymfony:2.xfrom
weaverryan:asset-mapper-support

Conversation

@weaverryan
Copy link
Copy Markdown
Contributor

@weaverryan weaverryan commented May 19, 2023 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Tickets None
License MIT

Adds:

  • A) Integration with new symfony.importmap key introduced to Flex in New "add-lines" configurator for simple file patching + importmap support flex#975
  • B) An "asset mapper" path in each bundle so that you can refer to the controller/files in that bundle.
  • C) Introduces new StimulusBundle (thanks to @jmsche for helping port from WebpackEncoreBundle). This includes the Twig stimulus_* functions + a revamped "helper" system for generating those attributes.
  • D) The new StimulusBundle also contains integration for AssetMapper to load custom controllers and controllers.json.

Cheers!

@weaverryan weaverryan changed the title [WIP] Adding Asset Mapper support to all components Adding Asset Mapper support to all components May 19, 2023
@weaverryan weaverryan changed the title Adding Asset Mapper support to all components Adding Asset Mapper support + new StimulusBundle May 21, 2023
@weaverryan weaverryan force-pushed the asset-mapper-support branch from b363fd9 to 8cb8c42 Compare May 22, 2023 00:39
@weaverryan
Copy link
Copy Markdown
Contributor Author

weaverryan commented May 22, 2023

This is ready for review - test failures are expected - the "low deps" aren't quite smart enough in the CI to know how to handle dependencies against packages that were added/updated inside the same PR. The "high deps" handle it correctly.

@weaverryan weaverryan mentioned this pull request May 22, 2023
Closed
nicolas-grekas
nicolas-grekas reviewed May 22, 2023
View reviewed changes
Comment thread .github/build-packages.php Outdated
Comment thread .github/build-packages.php Outdated
Comment thread src/Autocomplete/CHANGELOG.md Outdated
Comment thread src/Chartjs/CHANGELOG.md Outdated
Comment thread src/Chartjs/CHANGELOG.md Outdated
Comment thread src/StimulusBundle/composer.json Outdated
Comment thread src/StimulusBundle/config/services.php Outdated
Comment thread src/StimulusBundle/doc/index.rst Outdated
Comment thread src/StimulusBundle/doc/index.rst Outdated
Comment thread src/StimulusBundle/doc/index.rst Outdated
@weaverryan weaverryan mentioned this pull request May 22, 2023
Merged
@weaverryan weaverryan force-pushed the asset-mapper-support branch from b0ba289 to b8acf1a Compare May 22, 2023 16:39
@weaverryan weaverryan merged commit e59691a into symfony:2.x May 22, 2023
@weaverryan weaverryan deleted the asset-mapper-support branch May 22, 2023 18:02
@weaverryan weaverryan mentioned this pull request May 22, 2023
Merged
weaverryan added a commit that referenced this pull request May 24, 2023
@weaverryan
bug #891 [Typed] Fixing bad namespace (weaverryan)
16d035d 
This PR was merged into the 2.x branch.

Discussion
----------

[Typed] Fixing bad namespace

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Tickets       | None
| License       | MIT

Introduced by accident in #887.

Commits
-------

b89c5ce Fixing bad namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weaverryan @nicolas-grekas